Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS-2166#Clarify the GitOps ZTP update process in Edge Computing #91492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

TELCODOCS-2166#Clarify the GitOps ZTP update process in Edge Computing #91492

wants to merge 1 commit into from
+79 −9

Conversation

amolnar-rh
Copy link
Contributor

@amolnar-rh amolnar-rh commented Apr 2, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 2, 2025 •
edited
Loading

🤖 Fri Apr 04 08:46:44 - Prow CI generated the docs preview:

https://91492--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/ztp-preparing-the-hub-cluster.html
https://91492--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/ztp-updating-gitops.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2025
@amolnar-rh amolnar-rh force-pushed the TELCODOCS-2166 branch 3 times, most recently from 67b9c41 to c6d8b2d Compare April 2, 2025 13:12
@danielchg
Copy link

LGTM

@dgonyier
Copy link

dgonyier commented Apr 2, 2025

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 2, 2025

@dgonyier: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dgonyier
Copy link

dgonyier commented Apr 2, 2025

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 2, 2025

@dgonyier: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amolnar-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 2, 2025
@michaelryanpeter
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 2, 2025
michaelryanpeter
michaelryanpeter reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few very minor style issues. Great work!

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 2, 2025
@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Apr 2, 2025
@amolnar-rh
Copy link
Contributor Author

FYI, I just updated the ztp-enabling-assisted-installer-service-on-bare-metal.adoc with the relevant peer review comments for consistency. This file is the source for the content in ztp-pulling-ocp-images.adoc. However, not all steps were required so I couldn't just reuse the whole file but the shared steps are fully identical.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 4, 2025

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
6 participants
@amolnar-rh @ocpdocs-previewbot @danielchg @dgonyier @michaelryanpeter @ocpdocs-vale-bot