OBSDOCS-1596: Release notes for the Tempo 3.5.1 patch #91498
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@max-cx: This pull request references OBSDOCS-1596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
@max-cx: This pull request references OBSDOCS-1596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@max-cx: This pull request references OBSDOCS-1596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
max-cx
force-pushed
the
OBSDOCS-1596
branch
4 times, most recently
from
5482c78 to
116f35a
Compare
|
@max-cx: This pull request references OBSDOCS-1596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@max-cx: This pull request references OBSDOCS-1596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/label peer-review-in-progress |
openshift-ci
bot
added
peer-review-in-progress
|
/label peer-review-done |
openshift-ci
bot
added
peer-review-done
|
@max-cx: This pull request references OBSDOCS-1596 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
xenolinux
added
merge-review-in-progress
| [id="distr-tracing_3-5_tempo-release-notes_known-issues_{context}"] | ||
| ==== Known issues | ||
|
|
||
| There is currently a known issue: |
There was a problem hiding this comment.
this can be rephrased something like the following (if it doesn't hinder largely with the consistency in other files):
| There is currently a known issue: | |
| {TempoName} 3.5 has the following known issue: |
There was a problem hiding this comment.
Thank you for the suggestion.
Indeed, this would be a consistency issue for all other entries on this page.
To give you the context: I have used this wording based on guidance in https://redhat-documentation.github.io/supplementary-style-guide/#_known_issue.
There was a problem hiding this comment.
However, I like your suggestion because it eliminates the word currently from the lead-in sentence.
I have applied your suggestion above and in the other comment.
Thank you.
|
|
||
| The {TempoName} 3.5.1 update introduces the following breaking change: | ||
|
|
||
| * With this update, for a user to create or modify a `TempoStack` or `TempoMonolithic` custom resource with enabled multi-tenancy, the user must have permissions to create a TokenReview and SubjectAccessReview. |
There was a problem hiding this comment.
| * With this update, for a user to create or modify a `TempoStack` or `TempoMonolithic` custom resource with enabled multi-tenancy, the user must have permissions to create a TokenReview and SubjectAccessReview. | |
| * With this update, for a user to create or modify a `TempoStack` or `TempoMonolithic` custom resource with enabled multi-tenancy, the user must have permissions to create the `TokenReview` and `SubjectAccessReview` permissions for authorization. |
- Add an object name. See, https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#object-references
- Added "for authorization" as per the other instances in this PR for consistency
There was a problem hiding this comment.
Thank you for the suggestion.
I reworded it differently based on an OpenShift reference:
... the user must have permissions to create a `TokenReview`
and `SubjectAccessReview` authorization objects.
| [id="distr-tracing_3-5-1_tempo-release-notes_known-issues_{context}"] | ||
| ==== Known issues | ||
|
|
||
| There is currently a known issue: |
There was a problem hiding this comment.
Thank you for the suggestion.
Same reply as in #91498 (comment).
xenolinux
removed
the
merge-review-in-progress
max-cx
force-pushed
the
OBSDOCS-1596
branch
3 times, most recently
from
b3e3202 to
7285e5b
Compare
|
@max-cx: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 4.12, 4.13, 4.14, 4.15, 4.16, 4.17, 4.18, 4.19
Issue: https://issues.redhat.com/browse/OBSDOCS-1596
Link to docs preview:
QE review:
Additional information: