-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushing_changes_for_4.14 #91553
base: enterprise-4.14
Are you sure you want to change the base?
Pushing_changes_for_4.14 #91553
Conversation
🤖 Wed Apr 02 17:35:33 - Prow CI generated the docs preview: |
@Vaishali-gif-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. However, in this PR, some other lines are changed unlike in the original PR. Are these changes technically accurate for 4.14? Can you confirm with QE please?
Hi @OhadRevah - Could you please check and confirm? |
Version(s): 4.14
Issue:
https://issues.redhat.com/browse/CNV-45693
Link to docs preview:
QE review:
Additional information:
This change is already approved and updated for rest of the versions, except for 4.14.
https://github.com/openshift/openshift-docs/pull/89980/commits