Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing_changes_for_4.14 #91553

Open
wants to merge 1 commit into
base: enterprise-4.14
Choose a base branch
from

Conversation

Vaishali-gif-rh
Copy link
Contributor

Version(s): 4.14

Issue:
https://issues.redhat.com/browse/CNV-45693

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This change is already approved and updated for rest of the versions, except for 4.14.
https://github.com/openshift/openshift-docs/pull/89980/commits

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed Apr 02 17:35:33 - Prow CI generated the docs preview:

https://91553--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/monitoring/virt-prometheus-queries.html

Copy link

openshift-ci bot commented Apr 2, 2025

@Vaishali-gif-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Vaishali-gif-rh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 3, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.14 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 3, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. However, in this PR, some other lines are changed unlike in the original PR. Are these changes technically accurate for 4.14? Can you confirm with QE please?

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 3, 2025
@Vaishali-gif-rh
Copy link
Contributor Author

Hi @OhadRevah - Could you please check and confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants