-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fixed an ifndef error #9262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an ifndef error #9262
Conversation
It looks right to me. I'm glad it works locally! |
/cherrypick enterprise-3.10 |
@mburke5678: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-3.10 and openshift-cherrypick-robot:cherry-pick-9262-to-enterprise-3.10"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.9 |
@mburke5678: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-3.9 and openshift-cherrypick-robot:cherry-pick-9262-to-enterprise-3.9"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.7 |
@mburke5678: new pull request created: #9265 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.6 |
@mburke5678: new pull request created: #9267 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.5 |
@mburke5678: new pull request created: #9268 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-3.4 |
@mburke5678: new pull request created: #9269 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I was alerted to this error from a translation question (the pull-through feature phrase was repeated in Origin).
I made this change to the
ifndef
statement to match how similarifdef
statements are formatted. It works in an asciibinder build preview.@openshift/team-documentation PTAL to make sure this command is now correct.
ps. I noticed after-the-fact that the error was fixed in 3.9 and 3.10. #8038