-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Provisioned Service Details page and Edit Action for Plan/Configuration/Bindings #52
Conversation
beanh66
commented
Aug 2, 2017
- Adding a new page for provisioned service details
- Adding info for updating/ editing plans, configuration parameters and bindings
- Cleaning up old Binding pages and organizing content.
…r editing plan, configuration and bindings, and cleaning up binding pages
It might be worth mentioning in the documentation that the provisioned services pages represent service instances, but that we're using the more human-readable service class name as the primary identifier throughout the UI. The service instance name should definitely be included on the details page however, maybe underneath or next to the page title. The table that lists all of the services should also include the service instance name so that users can disambiguate if there are multiple instances of the same service class. |
@ncameronbritt Great point, I'll add that into the mocks and update! @cshinn @serenamarie125 let me know if you see anything else that needs to be changed as well 👍 |
@@ -14,7 +14,7 @@ | |||
- In the collapsed state, show the display name for the service class with the service instance name underneath. | |||
- The display name should link to a details page for that service instance. | |||
- If the provision service has a binding, it is listed under the label "Bindings." | |||
- If the service has nothing bound to it, the bindings section should be replaced by a create binding action. | |||
- If the service has nothing bound to it, the bindings section should be replaced by a create binding action. The pficon-add-circle-o icon should be shown in front of the "Create Binding" link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above image does not include the circle icon mentioned here. Is that the intended appearance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @cshinn, I was lazy and didn't update the image :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to initial Origin Web Console PR #1906 |