Skip to content

Improving argspec names #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

chouseknecht
Copy link
Contributor

Makes long argspec names, which stem from recursion into the model, more meaningful by deriving the name from the recursed property class, rather than the property name. This changes yields the following examples from the deployment model:

  • deployment_spec_deployment_strategy_type
  • deployment_spec_label_selector_match_labels
  • deployment_spec_pod_template_spec_pod_spec_active_deadline_seconds

In addition to hopefully making the longer names be more friendly, this also adds alisases to the long names. Take the above examples, we get the following aliases in the respective order:

  • strategy_type
  • label_selector_match_labels
  • pod_active_deadline_seconds

Also, adds ARGS_ATTRIBUTES_BLACKLIST as a list of attributes included in the argspec property that module_utils/k8s_common.py should remove when building the argument_spec. And yes, that's been updated to build an argument_spec from the data returned by the argspec property in hopes of helping Ansible contributors understand how the argumentspec gets built, and potentially impact it, if needed.

@detiber detiber self-requested a review February 27, 2017 21:50
@detiber detiber merged commit ca77043 into openshift:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants