-
Notifications
You must be signed in to change notification settings - Fork 71
[release-4.15] OCPBUGS-56463: fix(olm): improve error logging for missing olm.managed label (#3558) #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.15
Are you sure you want to change the base?
Conversation
Previously, nonconforming CRDs (missing the label) were logged as INFO, but this caused the to enter a CrashLoopBackOff state due to unhandled inconsistencies. This commit raises the log level to and enhances the message with actionable advice, clarifying that users should either delete CRDs for uninstalled solutions or label them appropriately. The root cause of the scenario is: From an old release (ocp 4.15) the component managed by OLM should have the label olm.managed: true added to comply with the new checks. Upstream-repository: operator-lifecycle-manager Upstream-commit: 1d9eafd4278ec97ea4caa1b6d56d5f901d550374
@openshift-cherrypick-robot: Jira Issue OCPBUGS-56358 has been cloned as Jira Issue OCPBUGS-56463. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56463, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-olm |
/jira refresh |
@camilamacedo86: This pull request references Jira Issue OCPBUGS-56463, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-gcp-olm |
/test e2e-gcp-olm |
/label qe-approved |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56463, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/test e2e-gcp-olm |
3 similar comments
/test e2e-gcp-olm |
/test e2e-gcp-olm |
/test e2e-gcp-olm |
/test e2e-gcp-olm |
2 similar comments
/test e2e-gcp-olm |
/test e2e-gcp-olm |
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/skip e2e-gcp-olm We could prove that it has no relation to the change |
This is an automated cherry-pick of #1006
/assign openshift-cherrypick-robot