Skip to content

Bug 2034319: Sync constraint changes #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 28, 2022
Merged

Bug 2034319: Sync constraint changes #248

merged 6 commits into from
Jan 28, 2022

Conversation

tylerslaton
Copy link
Contributor

@tylerslaton tylerslaton commented Jan 27, 2022 •
edited
Loading

@dinhxuanvu
fix(constraint): Correct the message field to be failureMessage (open…
46ea485 
…shift#211)

The constraint EP uses `failureMessage`, not `message`. This is a
mistake that should be corrected.

Signed-off-by: Vu Dinh <[email protected]>

Upstream-repository: api
Upstream-commit: 160240770853d11a62b3ff721b3ffed2d8edf06d
@dinhxuanvu
chore(constraint): Correct message to failureMessage in olm.constrain…
6dce29c 
…t schema (#2572)

The correct field for olm.constraint is `failureMessage` instead of `message`
as it is currently in the code. This change is to honor the field name that
is specified in the original enhancement.

Signed-off-by: Vu Dinh <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 25a7159cf292bb9de7164a4db2c1e9c3e402a489
@dinhxuanvu
fix(render/diff): Support olm.constraint in opm render/diff cmd (open…
0d3db55 
…shift#901)

* fix(render/diff): Support olm.constraint in opm render/diff cmd

Currently, the olm.constraint type is ignored and not recognized in
render and diff cmd. This commit is to add supoprt for constraint
type.

Signed-off-by: Vu Dinh <[email protected]>

* Accept any non-specific dependency as property

Clean up test code

Signed-off-by: Vu Dinh <[email protected]>

Upstream-repository: operator-registry
Upstream-commit: 4e339285b95dad2e635204ff85826aa6099ee6a3
@openshift-ci openshift-ci bot requested review from exdx and gallettilance January 27, 2022 19:52
@tylerslaton tylerslaton changed the title Sync constraint changes Bug 2034319: Sync constraint changes Jan 27, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@tylerslaton: This pull request references Bugzilla bug 2034319, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2034319: Sync constraint changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 27, 2022
@tylerslaton tylerslaton force-pushed the sync-constraint-changes branch 3 times, most recently from 3271f0f to 4731eae Compare January 27, 2022 21:43
@tylerslaton
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@tylerslaton: This pull request references Bugzilla bug 2034319, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tylerslaton
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@tylerslaton: This pull request references Bugzilla bug 2034319, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 27, 2022
@kevinrizza
Copy link
Member

/approve
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@tylerslaton
refactor(constraint): update none compound constraint to be not (open…
6a95e25 
…shift#221)

Signed-off-by: Tyler Slaton <[email protected]>

Upstream-repository: api
Upstream-commit: 96da8f9eb8f5d77bfcc41d05e26753c40b0fa33a
@tylerslaton
chore: update o-f/api version to v0.12.0 (openshift#911)
a289672 
Signed-off-by: Tyler Slaton <[email protected]>

Upstream-repository: operator-registry
Upstream-commit: 00dbb12bb5e34e8b96bf21cd68e8fca9cde3ae20
@tylerslaton
feat: update api version to be 0.12.0 in order to use new Not constra…
fbfd54e 
…int (#2603)

Signed-off-by: Tyler Slaton <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 7a6de4804c92a309fa085a189a9fdf37ece2a731
@tylerslaton tylerslaton force-pushed the sync-constraint-changes branch from 4731eae to fbfd54e Compare January 27, 2022 22:51
@timflannagan
Copy link
Contributor

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@tylerslaton: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5863540 into openshift:master Jan 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2022

@tylerslaton: All pull requests linked via external trackers have merged:

Bugzilla bug 2034319 has been moved to the MODIFIED state.

In response to this:

Bug 2034319: Sync constraint changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tylerslaton tylerslaton deleted the sync-constraint-changes branch January 28, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exdx exdx Awaiting requested review from exdx

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tylerslaton @kevinrizza @timflannagan @openshift-bot @openshift-merge-robot @dinhxuanvu