Skip to content

4.7 csv metrics #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented May 3, 2022

4.7 Backport of #288

awgreene and others added 3 commits May 3, 2022 11:37
Problem: The getMetricsFromPod function assumes that metrics are exposed
on port 8080. This function fails to retrieve metrics from the olm or
catalog operator when the port is changed.

Solution: Name the port in each of the deployments and update the
getMetricsFromPod function to infer the port number from the
deployments.

Signed-off-by: Alexander Greene <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 08a1d4b2f06fda1a6d6b4cadf779e1ce2259af3e
Signed-off-by: Josef Karasek <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: de4bebe06ba076f804d28c594d7dc52dfd95ef20
Signed-off-by: akihikokuroda <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 33b081aca79dcfc33895a5c114976c4f284f027f
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

@anik120: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

4.7 csv metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to backport this to 4.7? IIRC the upstream repository is still responsible for building the 4.6 and 4.7 release branches?

@timflannagan
Copy link
Contributor

Do we need to backport this to 4.7? IIRC the upstream repository is still responsible for building the 4.6 and 4.7 release branches?

Oh whoops: I just saw your slack message so it sounds like you already know this 😆

@anik120
Copy link
Contributor Author

anik120 commented May 3, 2022

Yes apologies totally slipped my mind that 4.7 is being built from the upstream repository. I've opened the backport PR here. Closing this one.

@anik120 anik120 closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants