-
Notifications
You must be signed in to change notification settings - Fork 70
Explicitly override the global catalog namespace #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly override the global catalog namespace #345
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-gcp-olm-flaky |
94aa414
to
826a82a
Compare
/lgtm |
Signed-off-by: timflannagan <[email protected]> Upstream-commit: c652154fd7eeb72a23f78856b2cbade775efad41 Upstream-repository: operator-lifecycle-manager
Signed-off-by: timflannagan <[email protected]>
826a82a
to
d3b55f9
Compare
It("[FLAKE] the broken subscription should resolve and have state AtLatest", func() { | ||
It("the broken subscription should resolve and have state AtLatest", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this was massaged into the original commit that downstreaming the global catalog exclusion work from upstream. This was added as a downstream-only change that I missed when originally opening the PR.
/retest |
/lgtm |
Overriding upgrade check. These changes only affect our testing suite, and nothing user facing. /override ci/prow/e2e-upgrade |
@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@timflannagan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Update the staging OLM testing suite, and override the E2E_CATALOG_NS and configure the global catalog namespace to the openshift-marketplace namespace. This should fix the permafailing global catalog exclusion tests as they were previously pointing to the wrong downstream namespace.