Skip to content

Explicitly override the global catalog namespace #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Contributor

@timflannagan timflannagan commented Jul 29, 2022

Update the staging OLM testing suite, and override the E2E_CATALOG_NS and configure the global catalog namespace to the openshift-marketplace namespace. This should fix the permafailing global catalog exclusion tests as they were previously pointing to the wrong downstream namespace.

@openshift-ci openshift-ci bot requested review from anik120 and kevinrizza July 29, 2022 02:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@timflannagan
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
Signed-off-by: timflannagan <[email protected]>

Upstream-commit: c652154fd7eeb72a23f78856b2cbade775efad41
Upstream-repository: operator-lifecycle-manager
@timflannagan timflannagan force-pushed the wip/global-catalog-flake-test branch from 826a82a to d3b55f9 Compare July 29, 2022 15:09
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
It("[FLAKE] the broken subscription should resolve and have state AtLatest", func() {
It("the broken subscription should resolve and have state AtLatest", func() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was massaged into the original commit that downstreaming the global catalog exclusion work from upstream. This was added as a downstream-only change that I missed when originally opening the PR.

@timflannagan
Copy link
Contributor Author

/retest

@oceanc80
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@timflannagan
Copy link
Contributor Author

Overriding upgrade check. These changes only affect our testing suite, and nothing user facing.

/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-upgrade

In response to this:

Overriding upgrade check. These changes only affect our testing suite, and nothing user facing.

/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 956fa85 into openshift:master Jul 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

@timflannagan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants