OCPBUGS-4950: Bump go and k8s #408
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: timflannagan <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: b833ecb1f4d15f5bf5641c14ba8ef737c793ea92
awgreene
force-pushed
the
bump-go-and-k8s
branch
5 times, most recently
from
b4f5112 to
cfc8dd8
Compare
This commit performs a number of small changes to support upgrading our kubernetes dependencies to v0.25.3 Signed-off-by: Alexander Greene <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: a67c1155a7751eb00344c918761d9b19a8a493d3
* go.*,vendor: Bump the sigs.k8s.io/kind testing dependency Signed-off-by: Alexander Greene <[email protected]> * Fix deprecated installPlan step resource test Signed-off-by: Alexander Greene <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 49533b50e9d2ccac34e38f278cfebb262a9cb276
awgreene
force-pushed
the
bump-go-and-k8s
branch
2 times, most recently
from
a1699e2 to
33be322
Compare
Signed-off-by: Alexander Greene <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 1f8ccd108548a28973a96605d2c30ec3168cbd33
awgreene
force-pushed
the
bump-go-and-k8s
branch
from
33be322 to
a7e6434
Compare
This downstream only commit also affects one of the downstream only dependencies in /staging/operator-lifecycle-manager, which will cause `make verify` to fail.
awgreene
force-pushed
the
bump-go-and-k8s
branch
from
a7e6434 to
1e01310
Compare
|
/retest |
|
/test e2e-gcp-olm |
Makefile
Outdated
| @@ -14,7 +14,7 @@ BUILD_DATE := $(shell date -u +'%Y-%m-%dT%H:%M:%SZ') | |||
| GIT_COMMIT := $(if $(SOURCE_GIT_COMMIT),$(SOURCE_GIT_COMMIT),$(shell git rev-parse HEAD)) | |||
|
|
|||
| GO_BUILD_OPTS := -mod=vendor | |||
| GO_BUILD_TAGS := -tags "json1" | |||
| GO_BUILD_TAGS := -tags "json1 e2e" | |||
There was a problem hiding this comment.
/hold
I just want confirm that this is causing e2e failures, we cannot allow this to merge.
openshift-ci
bot
added
the
do-not-merge/hold
awgreene
force-pushed
the
bump-go-and-k8s
branch
from
3689af4 to
c2bfb36
Compare
|
/retest |
|
This is ready to merge. Test is failing as expected given that one of the downstream commits had to modify a staged go dependency. |
|
@awgreene: Overrode contexts on behalf of awgreene: ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR shouldn't require approval from px or docs, it may require approval from qe, but I'll leave that to @jianzhangbjz to decide. |
openshift-ci
bot
added
px-approved
|
LGTM, create a cluster with this PR via the cluster-bot. MacBook-Pro:~ jianzhang$ oc get csv -n default
NAME DISPLAY VERSION REPLACES PHASE
etcdoperator.v0.9.4 etcd 0.9.4 etcdoperator.v0.9.2 Succeeded
rhacs-operator.v3.72.1 Advanced Cluster Security for Kubernetes 3.72.1 rhacs-operator.v3.72.0 Succeeded
MacBook-Pro:~ jianzhang$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.12.0-0.ci.test-2022-11-29-015710-ci-ln-icmg8qb-latest True False 50m Cluster version is 4.12.0-0.ci.test-2022-11-29-015710-ci-ln-icmg8qb-latest/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/lgtm |
|
/test e2e-gcp-olm |
|
/override ci/prow/verify |
|
@jianzhangbjz: jianzhangbjz unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold Revision c2bfb36 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/override ci/prow/verify |
|
@awgreene: Overrode contexts on behalf of awgreene: ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@awgreene: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@awgreene: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-4950 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.12 |
|
@awgreene: new pull request created: #424 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upstream-repository: api Upstream-commit: f522173c0d936ea1904076f1b4abc343e020b806
No description provided.