Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-4757: Default to legacy psa settings (#273) #420

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

awgreene
Copy link
Contributor

The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted".

In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default.

Signed-off-by: Alexander Greene [email protected]

@awgreene
Copy link
Contributor Author

/hold until operator-framework/operator-marketplace#491 merges.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2022
@openshift-ci openshift-ci bot requested review from anik120 and benluddy December 10, 2022 15:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2022
@awgreene awgreene changed the title Default to legacy psa settings (#273) OCPBUGS-3881: Default to legacy psa settings (#273) Dec 10, 2022
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-3881, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted".

In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default.

Signed-off-by: Alexander Greene [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 10, 2022
@awgreene
Copy link
Contributor Author

/retest

@awgreene awgreene changed the title OCPBUGS-3881: Default to legacy psa settings (#273) OCPBUGS-4757: Default to legacy psa settings (#273) Dec 12, 2022
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-4757, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted".

In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default.

Signed-off-by: Alexander Greene [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-4757, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2022
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-4757, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz December 12, 2022 20:01
@awgreene awgreene force-pushed the bump-api branch 2 times, most recently from 7a78783 to ce0af1b Compare December 13, 2022 02:43
@jianzhangbjz
Copy link
Contributor

Verify failed, details: https://issues.redhat.com/browse/OCPBUGS-4757
/hold

@awgreene
Copy link
Contributor Author

/retest

@awgreene
Copy link
Contributor Author

This PR will need the upstream changes introduced here: operator-framework/operator-lifecycle-manager#2906

@awgreene awgreene force-pushed the bump-api branch 3 times, most recently from 32283ce to 205562a Compare December 14, 2022 21:50
@awgreene
Copy link
Contributor Author

/retest

The catalogSource api was recently updated to support running the
associated pod in a "restricted" workflow as defined by the Pod Security
Admission controller. By default, the catalogSource pods have been
configured to run in "restricted" mode, which is disruptive to customers
managing and deploying their own catalogSources as they need to rebuild
their catalogs to run in "restricted" mode if a namespace is marked as
"restricted".

In an effort to provide users with a bit more time to rebuilt their
catalogSources, this change configures catalogSources to run in "legacy"
mode by default. A series of other changes will be made to update the
namespaces associated with marketplace and olm  to support
catalogSources running in "legacy" mode by default.

Signed-off-by: Alexander Greene <[email protected]>

Upstream-repository: api
Upstream-commit: 9fe16de3fd69800828decd67cf41ba9c5c773106
@awgreene
Copy link
Contributor Author

/retest

@awgreene awgreene force-pushed the bump-api branch 5 times, most recently from 1ec24c4 to 6f8e290 Compare December 16, 2022 13:01
@awgreene
Copy link
Contributor Author

/test e2e-gcp-olm

With the recent changes to default to legacy mode, some distributions of
OLM are unable to run as the catalogSources are running in legacy mode
in restricted namespaces.

This commit configures the catalogSource pods in the e2e suite to run in
restricted mode.

Signed-off-by: Alexander Greene <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: d82537cd54934878bb109fde5515e0efdf798e47
@awgreene
Copy link
Contributor Author

/retest

2 similar comments
@awgreene
Copy link
Contributor Author

/retest

@awgreene
Copy link
Contributor Author

/retest

@awgreene
Copy link
Contributor Author

@jianzhangbjz this should be good for a retest.

auditLevel: restricted
auditVersion: latest
warnLevel: restricted
warnVersion: latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure we want latest here? there was a reason we pinned the version @anik120 do you remember it?

Copy link
Contributor Author

@awgreene awgreene Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the upstream chart values, we actually unset the warn and audit bits here as the namespaces are restricted in OpenShift, which is not the case upstream.

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@jianzhangbjz
Copy link
Contributor

Retest it and It works well, details: https://issues.redhat.com/browse/OCPBUGS-4757
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@jianzhangbjz
Copy link
Contributor

/label qe-approved

@jianzhangbjz
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2022

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8203567 into openshift:master Dec 20, 2022
@openshift-ci-robot
Copy link

@awgreene: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4757 has been moved to the MODIFIED state.

In response to this:

The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted".

In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default.

Signed-off-by: Alexander Greene [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@awgreene: new pull request created: #426

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants