Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-4955: Set ImagePullPolicy of bundle unpacker to "IfNotPresent" for image digests #425

Merged
merged 2 commits into from
Jan 6, 2023
Merged

OCPBUGS-4955: Set ImagePullPolicy of bundle unpacker to "IfNotPresent" for image digests #425

merged 2 commits into from
Jan 6, 2023

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Dec 19, 2022

Allows users to set an image pull policy of "IfNotPresent" for bundle unpacker by specifying an image digest.

@dtfranz
OCPBUGS-4955: Set ImagePullPolicy of bundle unpacker to "IfNotPresent…
c82ae78 
…" for image digests (#2908)

* Capture ImagePullPolicy selection from image as func, export for wider use, implement in bundle unpacker, add tests

Signed-off-by: Daniel Franz <[email protected]>

* Fixed using wrong image as reference for pull policy inference

Signed-off-by: Daniel Franz <[email protected]>

* Fixed unit test using wrong vars for path/image/etc.

Signed-off-by: Daniel Franz <[email protected]>

* Remove comment block

Signed-off-by: Daniel Franz <[email protected]>

* Generate hash just once for digestPath

Signed-off-by: Daniel Franz <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: cf85bf7e02b9ddc000ae28b92c69f28dbd2fae09
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 19, 2022
@openshift-ci-robot
Copy link

@dtfranz: This pull request references Jira Issue OCPBUGS-4955, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Allows users to set an image pull policy of "IfNotPresent" for bundle unpacker by specifying an image digest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtfranz
Copy link
Contributor Author

dtfranz commented Dec 19, 2022

/retest

@jianzhangbjz
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-4955, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 20, 2022
@openshift-ci-robot
Copy link

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-4955, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz December 20, 2022 03:35
@jianzhangbjz
Copy link
Contributor

Test fail, details: https://issues.redhat.com/browse/OCPBUGS-4955
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@dtfranz
run go mod commands
590671d 
Signed-off-by: dtfranz <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2022

@dtfranz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dtfranz
Copy link
Contributor Author

dtfranz commented Dec 21, 2022

Test fail, details: https://issues.redhat.com/browse/OCPBUGS-4955 /hold

Hi @jianzhangbjz , please re-test when you can. I've updated the branch and I believe your test should now pass.

@jianzhangbjz
Copy link
Contributor

LGTM, details: https://issues.redhat.com/browse/OCPBUGS-4955
/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 5, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@jianzhangbjz
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2e2abf8 into openshift:master Jan 6, 2023
@openshift-ci-robot
Copy link

@dtfranz: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4955 has been moved to the MODIFIED state.

In response to this:

Allows users to set an image pull policy of "IfNotPresent" for bundle unpacker by specifying an image digest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtfranz
Copy link
Contributor Author

dtfranz commented Feb 3, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 3, 2023
Merged
@openshift-cherrypick-robot
Copy link

@dtfranz: new pull request created: #439

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@perdasilva perdasilva Awaiting requested review from perdasilva

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@jianzhangbjz jianzhangbjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dtfranz @openshift-ci-robot @jianzhangbjz @grokspawn @openshift-cherrypick-robot @openshift-merge-robot