-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-17157: sync #531
OCPBUGS-17157: sync #531
Conversation
Signed-off-by: kevinrizza <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 82fab49ef724a060090b8fc65f714724351b16b7 Signed-off-by: Steve Kuznetsov <[email protected]>
* fixes operator-framework/operator-sdk#5995 * fix comment change * fix imports Upstream-repository: api Upstream-commit: fdfcb35e6d330fca94841b113c8140cf58930e35 Signed-off-by: Steve Kuznetsov <[email protected]>
We do not want to fail the job if codecov fails to upload the report due to rate limiting. Signed-off-by: Mikalai Radchuk <[email protected]> Upstream-repository: api Upstream-commit: 92e43415eb8799b2733cc2a98e667e0e7e8d39b8 Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Jordan Keister <[email protected]> Upstream-repository: operator-registry Upstream-commit: a71ca092204961ad1ede3db1079a7ac50439a1c3 Signed-off-by: Steve Kuznetsov <[email protected]>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 23.0.1+incompatible to 23.0.3+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v23.0.1...v23.0.3) Upstream-repository: operator-lifecycle-manager Upstream-commit: a7e3f3fba29a6b65695a96cc073a077f0058ab84 --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Steve Kuznetsov <[email protected]>
We want to use a partial object metadata query for CSVs to reduce resource utilization. We still want to ask questions about whether these CSVs are copied, so we need to refactor this method to take only object metadata. While it's not a perfect port of the previous logic, it defies explanation how an object would have all the other markings of being copied but the wrong status. Signed-off-by: Steve Kuznetsov <[email protected]> Upstream-repository: api Upstream-commit: 409ec70c6c889945acb0447397305aa5c2150ea2 Signed-off-by: Steve Kuznetsov <[email protected]>
…penshift#288) Signed-off-by: Steve Kuznetsov <[email protected]> Upstream-repository: api Upstream-commit: 704ae942c4a9a33a3326a7da9364bc59f20ae532 Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-17157, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…004) * go.mod: update operator-framework/api $ GOPROXY=direct go get github.com/operator-framework/api@master $ GOPROXY=direct go mod tidy $ GOPROXY=direct go mod vendor $ make gen-all Signed-off-by: Steve Kuznetsov <[email protected]> * registry: implement memory targets on gRPC servers This commit implements the GoDoc on the new CatalogSource field, adding memory requests, limits and $GOMEMLIMIT values for sources that opt into a memory target. Signed-off-by: Steve Kuznetsov <[email protected]> --------- Signed-off-by: Steve Kuznetsov <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 2c3928ec460a9354cb8d840da92d90900075e94d Signed-off-by: Steve Kuznetsov <[email protected]>
5df0bbc
to
f41c684
Compare
Btw, this PR should not merge until the My guess (hope) is that the e2e's here will fail until we've done that. |
It depends on what the server does with unknown fields on the CatalogSource API - it's backwards compatible so likely the fields will just be ignored on versions of the server that don't understand them. That being said, while it's likely safe to merge before, no need to do it. |
@joelanford I think your comment (and my response) are actually for operator-framework/operator-marketplace#527 |
/retest |
1 similar comment
/retest |
@stevekuznetsov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, stevekuznetsov, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stevekuznetsov: Jira Issue OCPBUGS-17157: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-17157 has not been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.