OCPBUGS-29192: [release-4.14]: Clear (existing) error cond from Subscription, once error resolved

[anik120]

The func removeSubsCond takes in a list of pointers to Subscription objects, modifies the objects that the pointers point to, but return a new list of those pointers. A PR included in the v0.25.0 release changed the way the output of that function was being used leading to a regression. This PR fixes the removeSubsCond function, fixing the regression as a result.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 54da66a9996632315827ba37e14823de6405b4d9

[anik120]

/jira cherry-pick OCPBUGS-29116

[openshift-ci-robot]

@anik120: Jira Issue OCPBUGS-29116 has been cloned as Jira Issue OCPBUGS-29192. Will retitle bug to link to clone.
/retitle OCPBUGS-29192: [release-4.14]: Clear (existing) error cond from Subscription, once error resolved

In response to this:

/jira cherry-pick OCPBUGS-29116

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [anik120]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@anik120: This pull request references Jira Issue OCPBUGS-29192, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-29116 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-29116 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The func removeSubsCond takes in a list of pointers to Subscription objects, modifies the objects that the pointers point to, but return a new list of those pointers. A PR included in the v0.25.0 release changed the way the output of that function was being used leading to a regression. This PR fixes the removeSubsCond function, fixing the regression as a result.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 54da66a9996632315827ba37e14823de6405b4d9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[grokspawn]

/lgtm

[oceanc80]

/label backport-risk-assessed

[jianzhangbjz]

Seems like no error message was reported when using a wrong catalog service, please have a look: https://issues.redhat.com/browse/OCPBUGS-29192
/hold

[anik120]

@jianzhangbjz commented on the ticket, looks like the "patch service" method that was being used for testing needs to be adjusted. The service we're patching for testing is being reset back. More details on the ticket.

[jianzhangbjz]

Hi @anik120 , thanks! Comments left there.

[jianzhangbjz]

/unhold

[jianzhangbjz]

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-29192?focusedId=24191085&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-24191085
/lgtm
/label cherry-pick-approved
/label qe-approved

[openshift-ci-robot]

@anik120: This pull request references Jira Issue OCPBUGS-29192, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-29116 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-29116 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

The func removeSubsCond takes in a list of pointers to Subscription objects, modifies the objects that the pointers point to, but return a new list of those pointers. A PR included in the v0.25.0 release changed the way the output of that function was being used leading to a regression. This PR fixes the removeSubsCond function, fixing the regression as a result.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 54da66a9996632315827ba37e14823de6405b4d9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c6e9911 and 2 for PR HEAD d8bed00 in total

[anik120]

/retest

[anik120]

@grokspawn had to rebase to include this commit which went in since the last time you'd lgtm-ed it, and include this commit for the backport too. Looking for an lgtm again, thank you!

[anik120]

/test e2e-gcp-ovn

[anik120]

/test e2e-gcp-olm

[openshift-ci]

@anik120: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[grokspawn]

/lgtm

[openshift-ci-robot]

@anik120: Jira Issue OCPBUGS-29192: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#686

Jira Issue OCPBUGS-29192 has been moved to the MODIFIED state.

In response to this:

The func removeSubsCond takes in a list of pointers to Subscription objects, modifies the objects that the pointers point to, but return a new list of those pointers. A PR included in the v0.25.0 release changed the way the output of that function was being used leading to a regression. This PR fixes the removeSubsCond function, fixing the regression as a result.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 54da66a9996632315827ba37e14823de6405b4d9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-registry-container-v4.14.0-202402211439.p0.g8e6f9eb.assembly.stream.el8 for distgit operator-registry.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202402211439.p0.g8e6f9eb.assembly.stream.el8 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2024-02-21-181159