Skip to content

AUTH-482: set required-scc for openshift workloads #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

AUTH-482: set required-scc for openshift workloads #703

merged 1 commit into from
Apr 23, 2024

Conversation

liouk
Copy link
Member

@liouk liouk commented Feb 28, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2024 •
edited by openshift-ci bot
Loading

@liouk: This pull request references AUTH-482 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
@liouk liouk changed the title WIP: AUTH-482: set required-scc for openshift workloads AUTH-482: set required-scc for openshift workloads Mar 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@liouk
Copy link
Member Author

liouk commented Mar 20, 2024

/retest

1 similar comment
@perdasilva
Copy link
Contributor

/retest

@liouk liouk force-pushed the required-scc branch 2 times, most recently from 068deaf to 794e5af Compare April 9, 2024 08:02
@liouk
Copy link
Member Author

liouk commented Apr 9, 2024

@perdasilva could you please advise on why ci/prow/verify might be failing? Those verifications all succeed locally; on CI there seems to be an issue with 0000_50_olm_00-clusterserviceversions.crd.yaml, but I can't figure out what.

@perdasilva
Copy link
Contributor

perdasilva commented Apr 9, 2024 •
edited
Loading

@perdasilva could you please advise on why ci/prow/verify might be failing? Those verifications all succeed locally; on CI there seems to be an issue with 0000_50_olm_00-clusterserviceversions.crd.yaml, but I can't figure out what.

@liouk I gave you bad advice before. What you need to run is make generate-manifests. Then amend your commit with the changes from that call. Then run make verify just to 👀 and it should pass in CI. Reach out to me on Slack if you're still running into issues. Apologies for the previous bad info.

@perdasilva
Copy link
Contributor

perdasilva commented Apr 11, 2024 •
edited
Loading

@liouk so, even running make generate-manifests didn't work. I've been investigating a bit and think it might be to do with a go version mismatch. Can you switch to 1.21 and re-rerun generate-manifests? Thank ought to fix the problem, but I'm still testing it in CI. I'll come back with confirmation. Update: yup that worked ^^

@perdasilva
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liouk, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@perdasilva
Copy link
Contributor

/retest

2 similar comments
@liouk
Copy link
Member Author

liouk commented Apr 12, 2024

/retest

@perdasilva
Copy link
Contributor

/retest

@perdasilva
Copy link
Contributor

Seems like something is funky here - but I'm really not sure why. I'll check out the PR and try to repro locally

@perdasilva
Copy link
Contributor

looking like flakes - going to retest but also see if I can determine the source of the issue

@perdasilva
Copy link
Contributor

/retest

1 similar comment
@perdasilva
Copy link
Contributor

/retest

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 263ec26 and 2 for PR HEAD e27e51b in total

@perdasilva
Copy link
Contributor

/retest

1 similar comment
@perdasilva
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 773439e and 1 for PR HEAD e27e51b in total

@perdasilva
Copy link
Contributor

/retest

1 similar comment
@liouk
Copy link
Member Author

liouk commented Apr 23, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7f5d2f7 into openshift:master Apr 23, 2024
13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.17.0-202404231146.p0.g7f5d2f7.assembly.stream.el9 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

@kramaranya kramaranya mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees

@perdasilva perdasilva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liouk @openshift-ci-robot @perdasilva @openshift-bot