OCPBUGS-42150: (fix) registry pods do not come up again after node failure (#3366)

[anik120]

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

[openshift-ci-robot]

@anik120: This pull request references Jira Issue OCPBUGS-42150, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-41981 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-41981 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [anik120]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anik120]

/test e2e-gcp-olm-flaky
/test e2e-gcp-olm

[jianzhangbjz]

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-42150
/lgtm
/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@anik120: This pull request references Jira Issue OCPBUGS-42150, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-41981 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-41981 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[perdasilva]

/retest

[kevinrizza]

/label backport-risk-assessed
/retest

[perdasilva]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 80f23f1 and 2 for PR HEAD a1c914c in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 80f23f1 and 2 for PR HEAD a1c914c in total

[openshift-ci]

@anik120: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@anik120: Jira Issue OCPBUGS-42150: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#872

Jira Issue OCPBUGS-42150 has been moved to the MODIFIED state.

In response to this:

PR 3201 attempted to solve for the issue by deleting the pods stuck in Terminating due to unreachable node. However, the logic to do that was included in EnsureRegistryServer, which only gets executed if polling in requested by the user.

This PR moves the logic of checking for dead pods out of EnsureRegistryServer, and puts it in CheckRegistryServer instead. This way, if there are any dead pods detected during CheckRegistryServer, the value of healthy is returned false, which inturn triggers EnsureRegistryServer.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: f2431893193e7112f78298ad7682ff3e1b179d8c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.14.0-202409192336.p0.g01eee9c.assembly.stream.el8.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.14.0-202409192336.p0.g01eee9c.assembly.stream.el8.
All builds following this will include this PR.