Skip to content

OCPBUGS-57019 OPRUN-3946: [Default Catalog Consistency Test]: cleanups and enhancements: Add output xml to the gitignore and remove unused code from Makefile #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

OCPBUGS-57019 OPRUN-3946: [Default Catalog Consistency Test]: cleanups and enhancements: Add output xml to the gitignore and remove unused code from Makefile #372

merged 1 commit into from
Jun 4, 2025

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jun 4, 2025 •
edited
Loading

@openshift-ci openshift-ci bot requested review from anik120 and tmshort June 4, 2025 12:55
@camilamacedo86 camilamacedo86 changed the title [Default Catalog Consistency Test]: clenups and enhancements: Add output xml to the gitignore and remove unused code from Makefile NO-ISSUE: [Default Catalog Consistency Test]: clenups and enhancements: Add output xml to the gitignore and remove unused code from Makefile Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 4, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: [Default Catalog Consistency Test]: clenups and enhancements: Add output xml to the gitignore and remove unused code from Makefile OCPBUGS-57019: [Default Catalog Consistency Test]: clenups and enhancements: Add output xml to the gitignore and remove unused code from Makefile Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request references Jira Issue OCPBUGS-57019, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title OCPBUGS-57019: [Default Catalog Consistency Test]: clenups and enhancements: Add output xml to the gitignore and remove unused code from Makefile OPRUN-3946: [Default Catalog Consistency Test]: cleanups and enhancements: Add output xml to the gitignore and remove unused code from Makefile Jun 4, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Jun 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 4, 2025 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references OPRUN-3946 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 4, 2025
@oceanc80
Copy link
Contributor

oceanc80 commented Jun 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2025
tmshort
tmshort reviewed Jun 4, 2025
View reviewed changes
openshift/default-catalog-consistency/test/validate/suite_test.go
}

var _ = Describe("Check Catalog Consistency", func() {
var _ = Describe("OLM-Catalog-Validation", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "OLMv1"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRT wants the name of the component: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1749049667418439?thread_ts=1748434430.004709&cid=C01CQA76KMX

They want the name to match the component.
If we add other name it might take other circle back
Not valuable.

Furthermore, the images are used in both versions v1 and v0 so far.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@camilamacedo86 camilamacedo86 mentioned this pull request Jun 4, 2025
Open
@camilamacedo86 camilamacedo86 changed the title OPRUN-3946: [Default Catalog Consistency Test]: cleanups and enhancements: Add output xml to the gitignore and remove unused code from Makefile OCPBUGS-57019 OPRUN-3946: [Default Catalog Consistency Test]: cleanups and enhancements: Add output xml to the gitignore and remove unused code from Makefile Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 4, 2025 •
edited by openshift-ci bot
Loading

@camilamacedo86: This pull request references Jira Issue OCPBUGS-57019, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references OPRUN-3946 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 requested a review from tmshort June 4, 2025 18:39
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort
Copy link
Contributor

tmshort commented Jun 4, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6bb442f into openshift:main Jun 4, 2025
11 checks passed
@openshift-ci-robot
Copy link

@camilamacedo86: Jira Issue OCPBUGS-57019: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-57019 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 deleted the cleanups-catalog branch June 4, 2025 20:23
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.20.0-202506042244.p0.g6bb442f.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.20.0-202506042244.p0.g6bb442f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 Awaiting requested review from anik120

@tmshort tmshort Awaiting requested review from tmshort

Assignees

@oceanc80 oceanc80

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camilamacedo86 @openshift-ci-robot @oceanc80 @tmshort @openshift-bot