Skip to content

Set Xms equal to Xmx at Elasticsearch startup #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukas-vlcek opened this issue Apr 19, 2017 · 4 comments
Closed

Set Xms equal to Xmx at Elasticsearch startup #383

lukas-vlcek opened this issue Apr 19, 2017 · 4 comments

Comments

@lukas-vlcek
Copy link
Contributor

We should not make it possible to start ES with Xms < Xmx. One of the reasons is that we may not be able to fully benefit from disabled swap (#206) via mlockall.

@ewolinetz
Copy link
Contributor

ewolinetz commented Apr 19, 2017

Do we have node sizing documentation currently that references sizing for ES that we can add to to make sure users are aware of this? We should make sure that this information is well dispersed in our docs since we are effectively changing how this will work on smaller test installations.

Or would this be alright since we change the Xmx based on the amount of memory available to the pod?

@jcantrill
Copy link
Contributor

@ewolinetz I dont see it as a huge issue to document. In practice, this is recommended way of running java servers to avoid GC issues. My suspicion is that any deployment quickly grabs all the memory it can anyway. And to your point, we adjust max heap based on whats available to the container.

@portante
Copy link
Contributor

I believe we should not allow the user to set Xms < Xmx, nor allow them to set Xmx, but derive Xmx from the size of the container as we do today, documenting the behavior of halving the container size for Xmx.

I believe we do most of that today, no?

lukas-vlcek added a commit to lukas-vlcek/origin-aggregated-logging that referenced this issue Apr 25, 2017
@lukas-vlcek
Copy link
Contributor Author

My first take on this #389

jcantrill pushed a commit to jcantrill/origin-aggregated-logging that referenced this issue Jun 2, 2017
Closes openshift#383

(cherry picked from commit 5ae268a)
jcantrill pushed a commit that referenced this issue Jun 16, 2017
Closes #383

(cherry picked from commit 5ae268a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants