Add annotation for logging visualization url #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcantrill
force-pushed
the
logging_annotation
branch
from
401a542 to
93c0a06
Compare
spadgett
requested changes
Aug 28, 2017
src/filters/annotation.js
Outdated
| @@ -24,6 +24,7 @@ angular.module('openshiftCommonUI') | |||
| "jenkinsBuildURL": ["openshift.io/jenkins-build-uri"], | |||
| "jenkinsLogURL": ["openshift.io/jenkins-log-url"], | |||
| "jenkinsStatus": ["openshift.io/jenkins-status-json"], | |||
| "loggingVisualURL": ["openshift.io/logging.ui.url"], | |||
There was a problem hiding this comment.
I'd prefer loggingUIURL to match the annotation (although I think openshift.io/logging.ui.hostname and loggingUIHostname would be more accurate, see my comment in the other PR).
You'll need to run grunt build to create the dist files
There was a problem hiding this comment.
See https://github.com/openshift/origin-web-common#contributing for how to run set up grunt
jcantrill
force-pushed
the
logging_annotation
branch
from
93c0a06 to
72feec8
Compare
|
@spadgett updated |
spadgett
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add annotation filter for logging.ui.hostname