Using truncate-long-text directive to truncate with see all link for long service descriptions. #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhamilto
requested changes
Oct 4, 2017
| @@ -3,7 +3,11 @@ | |||
| styled directly in origin-web-common. `truncated-content` is used by | |||
| origin-web-console in certain contexts. | |||
| --> | |||
There was a problem hiding this comment.
Add a comment explaining highlightKeywords and linkify are mutually exclusive options.
rhamilto
reviewed
Oct 4, 2017
| <span ng-if="!linkify || (highlightKeywords | size)" ng-bind-html="content | highlightKeywords : keywords" class="truncated-content"></span> | ||
| <span ng-if="linkify && !(highlightKeywords | size)" ng-bind-html="content | linkify : '_blank'" class="truncated-content"></span> | ||
| </span> | ||
| <!-- To avoid truncating in middle of a link, we only apply linkify to expanded content --> |
There was a problem hiding this comment.
<!-- To avoid truncating in middle of a link, we only apply linkify to expanded content -->
<!-- To avoid truncating in middle of a link, we only optionally apply linkify to expanded content -->
…long service descriptions. Remove prettify-json from directive since it's no longer used. Add linkify to description link, but only when in expanded state.
sg00dwin
force-pushed
the
truncate-long-service-description-issue2072
branch
from
65da8e0 to
2d76f24
Compare
openshift-ci-robot
added
the
size/M
|
@rhamilto pr updated and I'll open a WIP in orign-web-console for the related changes |
rhamilto
approved these changes
Oct 5, 2017
spadgett
approved these changes
Oct 5, 2017
jeff-phillips-18
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove prettify-json from directive since it's no longer used.
Add linkify to description link, but only when in expanded state.
Fixes openshift/origin-web-console#2072