-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve extension scripts and stylesheets as URLs #11
Conversation
return nil, err | ||
} | ||
c.addExtensionFiles(s.GenericAPIServer.Handler.NonGoRestfulMux) | ||
if err := c.addWebConsoleConfig(s.GenericAPIServer.Handler.NonGoRestfulMux); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprised this part is removed from looking at it
0dec2b3
to
9c8cc3f
Compare
9c8cc3f
to
3b47317
Compare
/retest |
@stevekuznetsov I assume this is a flake?
|
Yeah that is a weird one. |
/lgtm |
@abhgupta @jupierce Starting in 3.9, the web console will expect extension stylesheets and extension scripts to be URLs rather than files on the master filesystem. I'm working on openshift-ansible changes in openshift/openshift-ansible#6359 |
Switch extension scripts and stylesheets to use a URL rather than serving them from the master filesystem. The console index.html will reference the URLs directly in its
<script>
and<link>
tags.We plan to change the asset config extension scripts and stylesheets property names to make it clear that they're URLs as a follow-on.
/assign @jwforres
@deads2k @sspeiche FYI