Merge pull request #2627 from benjaminapetersen/issue/2614/membership-role-title

Automatic merge from submit-queue.

Add titles to roles in dropdown list on membership page

Partial Fix for 2614, at least as a short term until we decide on a better solution.  See the conversation for more details.

Adds titles to the menu items:

![screen shot 2018-01-03 at 11 18 25 am](https://user-images.githubusercontent.com/280512/34528830-1d9208b4-f078-11e7-96b3-1585bce2b90d.png)

Re: #2614

Author: openshift-merge-robot

app/views/membership.html

@@ -125,7 +125,7 @@ <h3>
                       ng-model="subject.newRole"
                       theme="bootstrap"
                       search-enabled="true"
-                      title="Select a new role for {{subjectKind.name}}"
+                      title="Select a new role for {{subject.name}}"
                       class="select-role"
                       flex>
                       <ui-select-match
@@ -134,8 +134,12 @@ <h3>
                       </ui-select-match>
                       <ui-select-choices
                         repeat="role as role in filteredRoles | filter: excludeExistingRoles(subject.roles) | filter: { metadata: { name: $select.search } } track by (role | uid)">
-                        <div ng-bind-html="role.metadata.name | highlight: $select.search"></div>
-                        <div ng-if="role | annotation : 'description'">
+                        <div
+                          ng-bind-html="role.metadata.name | highlight: $select.search"
+                          title="{{role.metadata.name}}"></div>
+                        <div
+                          ng-if="role | annotation : 'description'"
+                          title="{{role.metadata.name}}">
                           <small>{{role | annotation : 'description'}}</small>
                         </div>
                       </ui-select-choices>
@@ -245,8 +249,12 @@ <h3>
                         </ui-select-match>
                         <ui-select-choices
                           repeat="role as role in filteredRoles | filter: { metadata: { name: $select.search } } track by (role | uid)">
-                          <div ng-bind-html="role.metadata.name | highlight: $select.search"></div>
-                          <div ng-if="role | annotation : 'description'">
+                          <div
+                            ng-bind-html="role.metadata.name | highlight: $select.search"
+                            title="{{role.metadata.name}}"></div>
+                          <div
+                            ng-if="role | annotation : 'description'"
+                            title="{{role.metadata.name}}">
                             <small>{{role | annotation : 'description'}}</small>
                           </div>
                         </ui-select-choices>

dist/scripts/templates.js

@@ -10747,13 +10747,13 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "<div ng-if=\"mode.edit\" class=\"col-add-role\">\n" +
     "<div row>\n" +
-    "<ui-select ng-if=\"filteredRoles.length\" ng-model=\"subject.newRole\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a new role for {{subjectKind.name}}\" class=\"select-role\" flex>\n" +
+    "<ui-select ng-if=\"filteredRoles.length\" ng-model=\"subject.newRole\" theme=\"bootstrap\" search-enabled=\"true\" title=\"Select a new role for {{subject.name}}\" class=\"select-role\" flex>\n" +
     "<ui-select-match placeholder=\"Select a role\">\n" +
     "<span ng-bind=\"subject.newRole.metadata.name\"></span>\n" +
     "</ui-select-match>\n" +
     "<ui-select-choices repeat=\"role as role in filteredRoles | filter: excludeExistingRoles(subject.roles) | filter: { metadata: { name: $select.search } } track by (role | uid)\">\n" +
-    "<div ng-bind-html=\"role.metadata.name | highlight: $select.search\"></div>\n" +
-    "<div ng-if=\"role | annotation : 'description'\">\n" +
+    "<div ng-bind-html=\"role.metadata.name | highlight: $select.search\" title=\"{{role.metadata.name}}\"></div>\n" +
+    "<div ng-if=\"role | annotation : 'description'\" title=\"{{role.metadata.name}}\">\n" +
     "<small>{{role | annotation : 'description'}}</small>\n" +
     "</div>\n" +
     "</ui-select-choices>\n" +
@@ -10805,8 +10805,8 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<span ng-bind=\"newBinding.newRole.metadata.name\"></span>\n" +
     "</ui-select-match>\n" +
     "<ui-select-choices repeat=\"role as role in filteredRoles | filter: { metadata: { name: $select.search } } track by (role | uid)\">\n" +
-    "<div ng-bind-html=\"role.metadata.name | highlight: $select.search\"></div>\n" +
-    "<div ng-if=\"role | annotation : 'description'\">\n" +
+    "<div ng-bind-html=\"role.metadata.name | highlight: $select.search\" title=\"{{role.metadata.name}}\"></div>\n" +
+    "<div ng-if=\"role | annotation : 'description'\" title=\"{{role.metadata.name}}\">\n" +
     "<small>{{role | annotation : 'description'}}</small>\n" +
     "</div>\n" +
     "</ui-select-choices>\n" +