Should not be able to add the same secret or config map to an app twice #2226
Comments
|
@spadgett do you mean the in the DC's Environment Variables section ? Or BC's Build Secrets section ? |
|
@jeff-phillips-18 mind if I take this one ? |
|
go for it @jhadvig |
|
@jhadvig I mean on the secret or config map page. There's an "Add to Application" button. |
|
@spadgett what if the application contains two containers, where one of them already contains the secret/configMap... shouldn't we show the application if at least one of its containers doesn't contain the secret/configMap ? |
Good question. I think so. |
openshift-merge-robot
added a commit
that referenced
this issue
Oct 17, 2017
Automatic merge from submit-queue. Should not be able to add the same secret or config map to an application twice The `Add to Application` modal will only show applications which DC's won't contain the secret/configMap that user wants to add. In case one of the containers won't contain the secret/configMap the application will be shown in the dropbox, but the ref will be added only to the containers that don't contain the it. Unfortunately if, in case of multiple container DC, user chooses to specify a specific container, the checkbox of the container that already contains the ref wont be pre-selected, cause that could mislead the user that by unchecking the checkbox he could remove the ref from that specific container. Other option would be to pre-select the checkbox and also disable it, but that would require add the disable logic to the `select-container` directive. Wasn't sure if we need that ATM... @jeff-phillips-18 @spadgett PTAL Closes #2226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's doesn't make sense to add the same secret twice.
cc @cdcabrera
The text was updated successfully, but these errors were encountered: