Skip to content

Provisioned service page shows "Create Binding" for instances that aren't bindable #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spadgett opened this issue Oct 16, 2017 · 0 comments
Closed

Provisioned service page shows "Create Binding" for instances that aren't bindable #2271

spadgett opened this issue Oct 16, 2017 · 0 comments
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

Hello World (APB) is not bindable.

openshift web console 2017-10-16 13-19-30

cc @jeff-phillips-18
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P1 labels Oct 16, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 16, 2017
@spadgett spadgett self-assigned this Oct 16, 2017
@spadgett spadgett mentioned this issue Oct 16, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 17, 2017
@openshift-merge-robot
Merge pull request #2273 from spadgett/is-bindable
f950d1c 
Automatic merge from submit-queue.

Fix issues with bindings widget for service instances

- Don't show "Create Binding" when service instance is not bindable
- Fix empty content when there are no bindings and you don't have
  permission to add a binding
- Don't request all service classes and plans to show bindings. This is
  a large amount of data when we usually have the service class and plan
  already

Fixes #2271
Fixes #2270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
1 participant
@spadgett