Skip to content

Remove the large cube and message from the Deploy Image dialog #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jwforres opened this issue Oct 17, 2017 · 1 comment
Closed

Remove the large cube and message from the Deploy Image dialog #2288

jwforres opened this issue Oct 17, 2017 · 1 comment
Assignees
@rhamilto
Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Milestone
3.7.0

Comments

@jwforres
Copy link
Member

It wastes space and causes a scrollbar when you initially open the dialog which looks bad. We only had it originally because it was on a massive page and filled up the empty space.
@jwforres jwforres added area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Oct 17, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 17, 2017
@spadgett spadgett self-assigned this Oct 17, 2017
@beanh66
Copy link

beanh66 commented Oct 18, 2017

@jwforres Agreed! 👍

@rhamilto rhamilto assigned rhamilto and unassigned spadgett Oct 19, 2017
@rhamilto rhamilto mentioned this issue Oct 19, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 19, 2017
@openshift-merge-robot
Merge pull request #2307 from rhamilto/issue-2288
a579667 
Automatic merge from submit-queue.

Remove hero-icon and make empty-state-message more consistent

Fixes #2288 

dialog from within project BEFORE
![screen shot 2017-10-19 at 9 03 30 am](https://user-images.githubusercontent.com/895728/31773606-4234cab0-b4b1-11e7-815b-62889d0e0515.PNG)

now with the icon gone, the text should not be muted so as to be consistent with empty-state-message elsewhere.  and i think the horizontal rule being present before a selection is made helps clarify.  yea/nay?

dialog from catalog
![screen shot 2017-10-19 at 9 26 22 am](https://user-images.githubusercontent.com/895728/31773504-fa6daf44-b4b0-11e7-9409-2a7d0d5917db.PNG)

dialog from within project
![screen shot 2017-10-19 at 9 26 35 am](https://user-images.githubusercontent.com/895728/31773514-fe2a4188-b4b0-11e7-8511-bcf4f2af7c47.PNG)
![screen shot 2017-10-19 at 9 43 13 am](https://user-images.githubusercontent.com/895728/31773821-f9a570dc-b4b1-11e7-89e9-c113ab3f4856.PNG)

create page
![screen shot 2017-10-19 at 9 26 41 am](https://user-images.githubusercontent.com/895728/31773513-fe1cca3a-b4b0-11e7-92da-253704611131.PNG)
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@rhamilto @f0x11
Remove hero-icon and make empty-state-message more consistent
c0ee9be 
Fixes openshift#2288
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@rhamilto @f0x11
Remove hero-icon and make empty-state-message more consistent
99bd69d 
Fixes openshift#2288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

Labels
area/usability kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
4 participants
@rhamilto @spadgett @jwforres @beanh66