Skip to content

Marking all notifications can resurrect a cleared notification #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjaminapetersen opened this issue Oct 18, 2017 · 2 comments
Closed

Marking all notifications can resurrect a cleared notification #2302

benjaminapetersen opened this issue Oct 18, 2017 · 2 comments
Assignees
@benjaminapetersen
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Milestone
3.7.0

Comments

@benjaminapetersen
Copy link
Contributor

Steps to reproduce:

  • Open the notification drawer with a set of notifications
  • Clear via the "x" a notification
  • Click "mark all read" at the bottom of the drawer

All notifications currently in view are marked read, notifications previously cleared will suddenly become visible & will not be marked read.
@benjaminapetersen benjaminapetersen self-assigned this Oct 18, 2017
@benjaminapetersen benjaminapetersen added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Oct 18, 2017
@benjaminapetersen
Copy link
Contributor Author

@jwforres @spadgett

@jwforres jwforres added this to the 3.7.0 milestone Oct 18, 2017
benjaminapetersen added a commit to benjaminapetersen/origin-web-console that referenced this issue Oct 19, 2017
@benjaminapetersen
Fix issue openshift#2302: marking all notifications read can resurrec…
10e9c0c 
…t cleared notifications
@benjaminapetersen benjaminapetersen mentioned this issue Oct 19, 2017
Closed
benjaminapetersen added a commit to benjaminapetersen/origin-web-console that referenced this issue Oct 20, 2017
@benjaminapetersen
Fix issue openshift#2302: marking all notifications read can resurrec…
2b74b86 
…t cleared notifications
spadgett pushed a commit to spadgett/origin-web-console that referenced this issue Oct 23, 2017
@benjaminapetersen @spadgett
Fix issue openshift#2302: marking all notifications read can resurrec…
57d0abd 
…t cleared notifications
openshift-merge-robot added a commit that referenced this issue Oct 23, 2017
@openshift-merge-robot
Merge pull request #2346 from spadgett/ben-cleared-notifications
f24d4fc 
Automatic merge from submit-queue.

Fix issue #2302: marking all notifications read can resurrect cleared notifications

This is the same as #2318, but rebased on current master.

@benjaminapetersen I've left you as the commit author
@spadgett
Copy link
Member

Fixed by #2346

f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@benjaminapetersen @f0x11
Fix issue openshift#2302: marking all notifications read can resurrec…
340ff8f 
…t cleared notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminapetersen benjaminapetersen

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
3 participants
@benjaminapetersen @spadgett @jwforres