Skip to content

Scrollbar back in deploy image dialog #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spadgett opened this issue Oct 23, 2017 · 0 comments
Closed

Scrollbar back in deploy image dialog #2356

spadgett opened this issue Oct 23, 2017 · 0 comments
Assignees
@rhamilto
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

It looks like the horizontal rule in openshift/origin-web-catalog#493 reintroduced the scrollbar to the deploy image dialog.

screen shot 2017-10-23 at 4 12 53 pm
@spadgett spadgett added area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Oct 23, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 23, 2017
@rhamilto rhamilto mentioned this issue Oct 24, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 24, 2017
@openshift-merge-robot
Merge pull request #2365 from rhamilto/issue-2356
ddf87bf 
Automatic merge from submit-queue.

Adjust display of empty state message and Ace editor

in deploy image and import yaml/json modals

Fixes #2356 

![screen shot 2017-10-24 at 12 50 31 pm](https://user-images.githubusercontent.com/895728/31956709-48348d8a-b8ba-11e7-840c-5a9396f27627.PNG)
![screen shot 2017-10-24 at 12 50 42 pm](https://user-images.githubusercontent.com/895728/31956710-483ff3c8-b8ba-11e7-8987-5ff61be8e683.PNG)
![screen shot 2017-10-24 at 12 51 00 pm](https://user-images.githubusercontent.com/895728/31956711-48503ed6-b8ba-11e7-84ca-818aaa29cff9.PNG)
![screen shot 2017-10-24 at 12 51 22 pm](https://user-images.githubusercontent.com/895728/31956712-485abe42-b8ba-11e7-99cd-737809466ba2.PNG)
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@rhamilto @f0x11
Adjust display of empty state message and Ace editor
83fbbad 
in deploy image and import yaml/json modals

Fixes openshift#2356
f0x11 pushed a commit to f0x11/origin-web-console that referenced this issue Mar 26, 2018
@rhamilto @f0x11
Adjust display of empty state message and Ace editor
7677970 
in deploy image and import yaml/json modals

Fixes openshift#2356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@rhamilto @spadgett