Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extremely difficult to scroll inside wizard on iPhone #2450

Closed
spadgett opened this issue Nov 3, 2017 · 1 comment
Closed

Extremely difficult to scroll inside wizard on iPhone #2450

spadgett opened this issue Nov 3, 2017 · 1 comment
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@spadgett
Copy link
Member

spadgett commented Nov 3, 2017

Sometimes the page behind the wizard scrolls instead of the wizard content itself. When this happens, it's difficult to figure out how to make the content itself scroll.

When you finally are able to scroll the content, it feels sticky / sluggish.
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Nov 3, 2017
@spadgett spadgett self-assigned this Nov 3, 2017
@spadgett spadgett mentioned this issue Nov 3, 2017
Merged
@spadgett spadgett changed the title Extremely difficult to scroll inside wizard on mobile device Extremely difficult to scroll inside wizard on iPhone Nov 3, 2017
@spadgett
Copy link
Member Author

spadgett commented Nov 3, 2017

Verified this is only an issue on iOS Safari and not Chrome on Android.

openshift-merge-robot added a commit that referenced this issue Nov 3, 2017
@openshift-merge-robot
Merge pull request #2451 from spadgett/mobile-overlay-scroll
9387547 
Automatic merge from submit-queue.

Wizard fixes for iPhone

* Prevent page scrolling under the wizard dialog, making it difficult to scroll the wizard content itself
* Don't add custom scrollbar styles on iOS, which cause layout problems on an iPhone
* Reduce wizard max-height on iPhone to prevent the buttons being hidden on iPhone X

Closes #2450 

@rhamilto @jwforres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spadgett