Skip to content

Cleanup template logic around rollback deployment #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2016
Merged

Cleanup template logic around rollback deployment #1026

merged 1 commit into from
Dec 12, 2016

Conversation

jwforres
Copy link
Member

Fixes #127

@jwforres jwforres requested a review from spadgett December 12, 2016 20:22
@jwforres
Copy link
Member Author

also fixes an issue where Rollback wasn't enabling

spadgett
spadgett approved these changes Dec 12, 2016
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👍

@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 34b8dc9

@openshift-bot
Copy link

openshift-bot commented Dec 12, 2016 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/841/) (Base Commit: 617df3f)

@openshift-bot openshift-bot merged commit 998521b into openshift:master Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwforres @spadgett @openshift-bot