Skip to content

Refresh membership page when removing 'admin' role from current user #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benjaminapetersen
Copy link
Contributor

Fixes #1103

  • Adds a forceRefresh flag to AuthorizationService.getProjectRules to allow busting the rules cache
  • Ensures the edit mode is tested after every update
  • Falls back to manually updating a roleBindings if the list on roleBindings fails (which it will if the user removes admin from self)

@spadgett

- update canI filter
- update roleBinding list
	- since the next roleBinding request will fail
@benjaminapetersen benjaminapetersen force-pushed the issue-1103-membership-refresh-when-losing-admin branch from 1c2bf06 to 9573cce Compare January 13, 2017 20:46
@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 9573cce

@openshift-bot
Copy link

openshift-bot commented Jan 16, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/917/) (Base Commit: fa6f2af)

@openshift-bot openshift-bot merged commit 0102c49 into openshift:master Jan 16, 2017
@benjaminapetersen benjaminapetersen deleted the issue-1103-membership-refresh-when-losing-admin branch January 16, 2017 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants