Remove emptyMessage var if its not changing

[jhadvig]

Found out that there are place in the code where we use emptyMessage var as part of the scope, where we just set it to "No $resource to show" and thats it. So I've got rid of that and use the scoped loaded variable to check if the resources are loaded since we do it on most parts of the code.
Other option would be to get rid even of the loaded var and check only the resource variable, which wont be set by default in the controller... eg:

<div ng-if="!services">Loading...</div>
<div class="row" ng-if="services">
     <tbody ng-if="(services | hashSize) == 0">
         <tr><td colspan="4"><em>No image streams to show</em></td></tr>
     </tbody>
     <tbody ng-if="(imageStreams | hashSize) > 0">

Also removed emptyMessage var on places we didn't even used that variable in views.

Will add dist after review

@spadgett PTAL

Closes #1182

[spadgett]

@jhadvig I think the places we should make this change are

• When the message doesn't switch from "Loading..." to "No resources to show" ($scope.emtpyMessage is set once and never changed)
• When we want different styles for empty states like Table Empty States V2 #497

Hesitant to change a lot working code if it's not for one of the two above reasons.

[jhadvig]

@spadgett ok, will update the PR so the changes only tackle mentioned reasons.
THanks !

[spadgett]

So we do have the other #497 for empty states. I think for now we should probably only look at places when $scope.emptyMessage is set once and never changed.

[jhadvig]

@spadgett PTAL

[spadgett]

This breaks the loading message on the browse -> pods page.

[spadgett]

Need to update traffic-table.html

https://github.com/spadgett/origin-web-console/blob/859a4cb2689c7bd8b5ef1a1c17ce8efcf267c758/app/views/directives/traffic-table.html#L15

[spadgett]

@jhadvig Thanks for removing some completely unused variables

[jhadvig]

@spadgett updated .. PTAL :)

[spadgett]

Thanks @jhadvig, will merge when the stream opens for 1.6

[jwforres]

@jhadvig needs to be rebased

[jwforres]

@jhadvig actually this PR shouldn't have been touching vendor.js at all, I'm not seeing a reason for it to, make sure you clean/install deps/build after you rebase

[spadgett]

actually this PR shouldn't have been touching vendor.js at all

It was from when we were pulling in the bootstrap-switch dependency update. Should disappear on the clean/install

[jhadvig]

It was from when we were pulling in the bootstrap-switch dependency update. Should disappear on the clean/install

yep

@jwforres @spadgett I've updated the PR, should be fine now

[spadgett]

[merge]

[openshift-bot]

Evaluated for origin web console merge up to f0588be

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1069/) (Base Commit: 36c701f)