Fix bug searching builders with tags that reference other tags #1243
+92
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If builder nodejs:latest tracks nodejs:4 and a search term matches only the nodejs:latest description, the version select appears empty in the add to project catalog. Fix this by only matching search terms in the nodejs:4 description (but still match searches for "latest").
|
@jwforres not for 1.5 |
jwforres
approved these changes
Feb 10, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 0677dee |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1045/) (Base Commit: e812e57) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If builder
nodejs:latesttracksnodejs:4and a search term matches only thenodejs:latestdescription, the version select appears empty in the add to project catalog.Fix this by only matching search terms in the nodejs:4 description (but still match searches for "latest").
Fixes #1242