Make route services pie chart responsive #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mobile:
Desktop:
|
spadgett
force-pushed
the
route-pie-legend-position
branch
from
7a0efae to
e75b262
Compare
jwforres
reviewed
Feb 20, 2017
| }; | ||
|
|
||
| if ($scope.route) { | ||
| data.columns.push(getData($scope.route.spec.to)); | ||
| data.names[$scope.route.spec.to.name] = _.trunc($scope.route.spec.to.name, { length: 30 }); |
There was a problem hiding this comment.
so the full name isn't available on hover either?
Fix problems on mobile and with long names
spadgett
force-pushed
the
route-pie-legend-position
branch
from
e75b262 to
50e0793
Compare
jwforres
approved these changes
Feb 20, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 50e0793 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to 50e0793 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1050/) (Base Commit: e812e57) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1065/) (Base Commit: a0d6ce8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problems on mobile and with long names.
Fixes #1274