Bug 1427289 - Fix log updates when switching containers #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
commented
Feb 28, 2017
| streamer.stop(); | ||
| streamer = null; |
There was a problem hiding this comment.
Already set to null at line 401 below
jwforres
reviewed
Feb 28, 2017
app/scripts/directives/logViewer.js
Outdated
| if($scope.state !== 'logs') { | ||
| // Prevent flicker switching from a container with an empty log | ||
| // to one with content. | ||
| if ($scope.state === 'empty') { |
There was a problem hiding this comment.
what happens if you go from empty to empty
There was a problem hiding this comment.
spadgett
force-pushed
the
fix-log-switch-containers
branch
from
b414f5a to
ee1010e
Compare
|
@jwforres updated |
jwforres
approved these changes
Feb 28, 2017
|
[merge] |
|
Not surprising but it was an AWS issue [merge]
…On Tue, Feb 28, 2017 at 5:07 PM, OpenShift Bot ***@***.***> wrote:
Origin Web Console Merge Results: FAILURE (https://ci.openshift.redhat.
com/jenkins/job/test_pull_requests_origin_web_console/1120/) (Base
Commit: cfbf483
<cfbf483>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1310 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZk7aBww5jFs81qW-gotFQhlCR92HJkks5rhJqVgaJpZM4MO6Bg>
.
|
|
[merge] |
The `onClose` callback for log streamers happens asynchronously. Make sure the `onClose` cleanup happens before we begin streaming the next container log. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427289
spadgett
force-pushed
the
fix-log-switch-containers
branch
from
ee1010e to
1280382
Compare
|
Pushed dist update [merge] |
|
Evaluated for origin web console merge up to 1280382 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1125/) (Base Commit: cfbf483) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onClosecallback for log streamers happens asynchronously. Make sure theonClosecleanup happens before we begin streaming the next container log.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427289
@jwforres mostly whitespace changes