Bug 1427360 - Correctly handle 0 values in MetricsService #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
commented
Mar 1, 2017
| @@ -25,9 +25,10 @@ angular.module("openshiftConsole") | |||
|
|
|||
| _.each(data, function(point) { | |||
| // Set point.value to the average or null if no average. | |||
| if (!point.value || point.value === "NaN") { | |||
There was a problem hiding this comment.
@jwforres point.value is never set by Hawkular (for requests using buckets), so I removed this check.
There was a problem hiding this comment.
jwforres
approved these changes
Mar 1, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 0f99675 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1126/) (Base Commit: 15ba89f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427360