Fix toggle link positioning for truncation directive #1316
Conversation
| @@ -4,15 +4,15 @@ | |||
| <span ng-attr-title="{{content}}"> | |||
| <span ng-bind-html="truncatedContent | highlightKeywords : keywords" class="truncated-content"></span>… | |||
| </span> | |||
| <a ng-if="expandable" href="" ng-click="toggles.expanded = true" style="margin-left: 5px; white-space: nowrap;">See all</a> | |||
| <a ng-if="expandable" href="" ng-click="toggles.expanded = true" class="truncated-content-toggle-link">See all</a> | |||
There was a problem hiding this comment.
If "See all" wraps by itself onto the next line, is the left margin wrong?
sg00dwin
force-pushed
the
collapse-link-issue1277
branch
from
0a87004 to
5dec7f7
Compare
|
@spadgett updated pr so margin is applied around content in collapsed state so it aligns if wrapped
|
app/styles/_core.less
Outdated
| margin-right: 10px; | ||
| } | ||
|
|
||
| .truncated-content-toggle-link { |
There was a problem hiding this comment.
I'd just call this .truncation-collapse-link since it is no longer for the see all link.
| <span ng-bind-html="truncatedContent | highlightKeywords : keywords" class="truncated-content"></span>… | ||
| </span> | ||
| <a ng-if="expandable" href="" ng-click="toggles.expanded = true" style="margin-left: 5px; white-space: nowrap;">See all</a> | ||
| <a ng-if="expandable" href="" ng-click="toggles.expanded = true" class="nowrap">See all</a> |
There was a problem hiding this comment.
Do you mind changing to headline case "See All" while you're in the code?
sg00dwin
force-pushed
the
collapse-link-issue1277
branch
from
5dec7f7 to
0140d25
Compare
|
@spadgett pr has been updated ptal |
|
[merge] |
|
Merge failed from dist mismatch |
sg00dwin
force-pushed
the
collapse-link-issue1277
branch
from
0140d25 to
19fa849
Compare
|
pushed an updated main.css. Lets see if that fixes it. |
|
[merge] |
|
Evaluated for origin web console merge up to 19fa849 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1143/) (Base Commit: fb5ff0b) |
Fixes #1277