Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update addTemplateModal fn to class, extract to separate file #1327

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Update addTemplateModal fn to class, extract to separate file #1327

merged 1 commit into from
Mar 8, 2017

Conversation

benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Mar 8, 2017 •
edited
Loading

Test cleanup, extract AddTemplateModal into separate page-object.

@benjaminapetersen
Copy link
Contributor Author

[TEST]

@benjaminapetersen benjaminapetersen force-pushed the test-cleanup-add-template-modal branch from 8304d5a to fd6d24d Compare March 8, 2017 18:13
@benjaminapetersen benjaminapetersen force-pushed the test-cleanup-add-template-modal branch from fd6d24d to b13118e Compare March 8, 2017 20:01
@openshift-bot
Copy link

Evaluated for origin web console test up to b13118e

@openshift-bot
Copy link

Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1148/) (Base Commit: 295a6c8)

@benjaminapetersen
Copy link
Contributor Author

@jwforres @spadgett quick test update

@jwforres
Copy link
Member

jwforres commented Mar 8, 2017

[merge]

@openshift-bot
Copy link

openshift-bot commented Mar 8, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1148/) (Base Commit: 295a6c8)

@openshift-bot
Copy link

Evaluated for origin web console merge up to b13118e

@openshift-bot openshift-bot merged commit 3fb4314 into openshift:master Mar 8, 2017
@benjaminapetersen benjaminapetersen deleted the test-cleanup-add-template-modal branch March 8, 2017 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwforres jwforres jwforres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaminapetersen @openshift-bot @jwforres