Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update attachPVC controller to use new DataService.list #1328

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Update attachPVC controller to use new DataService.list #1328

merged 1 commit into from
Mar 9, 2017

Conversation

benjaminapetersen
Copy link
Contributor

re: #799

@benjaminapetersen
Copy link
Contributor Author

@jwforres @spadgett minor tweak to plug away @ that list.

@jwforres
Copy link
Member

jwforres commented Mar 9, 2017

@benjaminapetersen looks like you have an unrelated dist change in main.css

@benjaminapetersen
Copy link
Contributor Author

Oop, thx, removed it.

@jwforres
Copy link
Member

jwforres commented Mar 9, 2017

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 717f1e2

@openshift-bot
Copy link

openshift-bot commented Mar 9, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1156/) (Base Commit: 4bc00c8)

@openshift-bot openshift-bot merged commit dfb604a into openshift:master Mar 9, 2017
@benjaminapetersen benjaminapetersen deleted the list-update-attach-pvc branch March 10, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwforres jwforres jwforres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaminapetersen @jwforres @openshift-bot