Fixed Cassandra icon style name #1486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Apr 28, 2017
| @@ -191,6 +191,6 @@ | |||
| .icon-apache:before { | |||
| content: "\f138"; | |||
| } | |||
| .icon-casadra:before { | |||
| .icon-casadra:before, .icon-cassandra:before { | |||
There was a problem hiding this comment.
Might be worth a comment here not to remove icon-casadra for backwards compatibility.
spadgett
reviewed
Apr 28, 2017
There was a problem hiding this comment.
Thanks @jpkrohling
@sg00dwin Do you know if it would cause a problem for us to make the same change in openshift-logos-icon.json and openshift-logos-icon.svg?
|
@spadgett I believe it would be fine |
spadgett
approved these changes
May 2, 2017
|
[merge] |
|
Evaluated for origin web console merge up to d939ccf |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1308/) (Base Commit: 66df3b8) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.