Support creating templates in a dialog #1492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncameronbritt fyi |
spadgett
force-pushed
the
template-dialog
branch
4 times, most recently
from
bf5d640 to
8125dac
Compare
jwforres
reviewed
May 1, 2017
|
|
||
| ctrl.close = function() { | ||
| var cb = ctrl.onDialogClosed(); | ||
| if (cb) { |
There was a problem hiding this comment.
if (_.isFunction(cb)) to be safe?
| <div ng-if="$ctrl.selectedProject.metadata.uid" class="row"> | ||
| <div ng-if="$ctrl.selectedProject.metadata.uid" class="col-sm-8 col-sm-offset-4"> | ||
| <!-- TODO: Preserve entered form values. --> | ||
| To configure additional template parameters, view |
There was a problem hiding this comment.
there are not necessarily additional parameters to configure though. In some cases labels may be the only thing you get out of going to advanced.
spadgett
force-pushed
the
template-dialog
branch
2 times, most recently
from
b1b65d7 to
727dfd7
Compare
spadgett
changed the title
|
Updated and added dist. @jwforres another look? |
jwforres
approved these changes
May 1, 2017
|
[merge] |
|
Evaluated for origin web console merge up to 63254d7 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1305/) (Base Commit: be96ed8) |
This was referenced May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/2A7x5Pbc
Fixes openshift/origin-web-catalog#177
Requires openshift/origin-web-catalog#193
Follow-on work: