Improve monitoring page collapsed rows #1812
Conversation
- Show how many containers are ready for individual pods - Use the mini pod donut for deployments and stateful sets The mini donut lets you click through to get to the pods and shows when pods are crashing and not ready.
| ng-switch-when="New"></span><span | ||
| ng-switch-when="Pending"></span><span | ||
| ng-switch-default>, ran for {{build.status.startTimestamp | duration : build.status.completionTimestamp}}</span> | ||
| <span ng-if="!build.status.reason || build.status.phase === 'Cancelled'">{{build.status.phase}}</span> |
There was a problem hiding this comment.
@jwforres This is only used on the monitoring page. I wanted it to be consistent with container ready for pods (see screenshot in description), and I think it's easier to scan the page without the "ran for..." It also takes less space, and we're somewhat space constrained here.
$ rg -thtml build-status
app/views/builds.html
105: <!-- <build-status build="build"></build-status> -->
app/views/monitoring.html
386: <build-status build="build"></build-status>
|
@ncameronbritt FYI |
| ng-switch-when="Pending"></span><span | ||
| ng-switch-default>, ran for {{build.status.startTimestamp | duration : build.status.completionTimestamp}}</span> | ||
| <span ng-if="!build.status.reason || build.status.phase === 'Cancelled'">{{build.status.phase}}</span> | ||
| <span ng-if="build.status.reason && build.status.phase !== 'Cancelled'">{{build.status.reason | sentenceCase}}</span> |
There was a problem hiding this comment.
is a pending build showing up correctly? i don't think it has a reason, its phase is not cancelled and it wouldn't have a startTimestamp
There was a problem hiding this comment.
Yeah. If it doesn't have a reason, the first ng-if is true.
|
LGTM for 3.7 |
|
[merge] |
1 similar comment
|
[merge] |
|
cc @jwforres looks like this might be a flake |
|
[merge] |
|
Evaluated for origin web console merge up to 5484782 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/14/) (Base Commit: adf6034) (PR Branch Commit: 5484782) |
|
Flake #1685 |
The mini donut lets you click through to get to the pods and shows when
pods are crashing and not ready.
Fixes #1489