Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility nav and Online extension point fixes #1841

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Utility nav and Online extension point fixes #1841

merged 1 commit into from
Jul 20, 2017

Conversation

rhamilto
Copy link
Member

Before:
mobile-before

After:
mobile-after

Before:
desktop-before

After:
desktop-after

And removes funky :hover:active:focus state from the Online extension point in the default mobile navbar:

screen shot 2017-07-13 at 10 24 19 am

@rhamilto rhamilto requested review from spadgett and sg00dwin July 13, 2017 14:34
@spadgett
Copy link
Member

Approved for 3.7

@spadgett
Copy link
Member

[merge]

@openshift-bot
Copy link

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for origin web console test up to 3d4c542

@openshift-bot
Copy link

Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/12/) (Base Commit: 15c6d1b) (PR Branch Commit: 3d4c542)

@spadgett
Copy link
Member

Flake #1684

ERROR - Unable to start a WebDriver session.

/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/lib/atoms/error.js:113
  var template = new Error(this.message);
                 ^
UnknownError: Unable to connect to host 127.0.0.1 on port 7055 after 45000 ms. Firefox console output:
Error: cannot open display: :10

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 3d4c542

@openshift-bot
Copy link

openshift-bot commented Jul 19, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/24/) (Base Commit: 27f6af5) (PR Branch Commit: 3d4c542)

@openshift-bot openshift-bot merged commit ecbb648 into openshift:master Jul 20, 2017
@rhamilto rhamilto deleted the utility-nav-fixes branch July 20, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants