Issue labelbinding #1943
Merged
Issue labelbinding #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Aug 16, 2017
app/scripts/constants.js
Outdated
| template_service_broker: false, | ||
| pod_presets: false | ||
| template_service_broker: true, | ||
| pod_presets: true |
There was a problem hiding this comment.
We should set these back to false in the PR so they're not enabled by default.
app/views/overview.html
Outdated
| @@ -358,7 +358,7 @@ <h2 ng-if="!app"> | |||
| </overview-list-row> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <h2>HELLO WORLD!</h2> | |||
There was a problem hiding this comment.
Probably want to remove that :)
amarie401
force-pushed
the
issue-labelbinding
branch
3 times, most recently
from
4976122 to
ad15d47
Compare
amarie401
force-pushed
the
issue-labelbinding
branch
from
ad15d47 to
5d2e2a5
Compare
|
@spadgett I have made the requested changes :) |
|
[merge][severity: bug] |
|
Evaluated for origin web console merge up to 5d2e2a5 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/78/) (Base Commit: bf2a6f2) (PR Branch Commit: 5d2e2a5) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the label for 'Applications Bindings' to just 'Bindings' for expanded Provisioned services. Closes #1939
@ncameronbritt @spadgett