add bower link instructions to README #1957
Conversation
README.md
Outdated
| $ bower link | ||
| $ cd ~/git-repos/origin-web-catalog | ||
| $ bower link | ||
| $ cd ~?git-repos/origin-web-console |
There was a problem hiding this comment.
+1 got it
benjaminapetersen
force-pushed
the
bpeterse/readme-update
branch
from
96f979e to
c9b8876
Compare
| $ bower link | ||
| $ cd ~/git-repos/origin-web-console | ||
| $ bower link origin-web-common | ||
| $ bower link origin-web-catalog |
There was a problem hiding this comment.
Do we need to tell people how to unlink? Will you have built dist conflicts if you don't?
@jeff-phillips-18 may know better
There was a problem hiding this comment.
bower link is just a symlink bower maintains so it shouldn't blow up across bower installs, etc.
You can definitely have /dist conflicts if one of the linked repos is on another branch, etc.
bower unlink is an alias of bower uninstall, which just removes the dependency for a re-install the normal way.
We can outline all of this if you think its necessary.
There was a problem hiding this comment.
Updated, how about this?
There was a problem hiding this comment.
Working out the kinks of it right now on other branches 😄
There was a problem hiding this comment.
You can definitely have /dist conflicts if one of the linked repos is on another branch, etc.
Even if master is ahead of the tagged version that origin-web-console uses, wouldn't it cause a dist mismatch? So we'd need instructions for dealing with that
There was a problem hiding this comment.
Hmm, yeah this is problematic. Options:
- Clone
origin-web-consoletwice, have a copy with thebower linksto work on the other repos. Wheeeee..... - See if we can improve on unit/integration testing instead of doing all this link stuff to manually verify things work as intended
- Setup a little demo app in the secondary repos to manually test against
- ???
All the options have a little bit of janky workflow in them.
benjaminapetersen
force-pushed
the
bpeterse/readme-update
branch
from
c9b8876 to
801fba4
Compare
README.md
Outdated
| # may end up with frequent `/dist` conflicts as `grunt build` will use the linked local copy | ||
| # in whatever state it happens to be in. | ||
| ``` | ||
| Alternatively, you could `cd` into `/origin-web-console/bower_components` and create symlinks for `origin-web-catalog` and `origin-web-common`, but you will likely have to recreate these each time you `bower install`. |
There was a problem hiding this comment.
I think we can just leave this out since bower link just seems better
README.md
Outdated
| # you will likely have to `grunt build` to see the updates. | ||
| # | ||
| # Reduce your complexity and clean up: | ||
| # when you have finished your work, `bower unlink <repo>` & `bower install` to return to using |
There was a problem hiding this comment.
Does that work? I'm thinking it might remove the dependency entirely from bower.json.
Let's just recommend
$ hack/clean-assets.sh
$ hack/install-assets.sh
to clean up.
benjaminapetersen
force-pushed
the
bpeterse/readme-update
branch
from
801fba4 to
31b80c1
Compare
|
updated |
|
[merge][severity: lowrisk] |
|
Evaluated for origin web console merge up to 31b80c1 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/161/) (Base Commit: 240041d) (PR Branch Commit: 31b80c1) (Extended Tests: lowrisk) |
Adds a block under
Contributingfor usingbower linkto work in our other repos.@jeff-phillips-18
@spadgett