Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow binding to an application when pod_presets is false #2009

Merged
merged 2 commits into from
Sep 6, 2017

Conversation

jeff-phillips-18
Copy link
Member

Depends on origin-web-common release with openshift/origin-web-common#167

@jeff-phillips-18
Copy link
Member Author

Added commit to bump origin-web-common to 0.0.52.

Removed WIP status.

@jeff-phillips-18 jeff-phillips-18 changed the title [WIP] Do not allow binding to an application when pod_presets is false Do not allow binding to an application when pod_presets is false Sep 5, 2017
@spadgett
Copy link
Member

spadgett commented Sep 5, 2017

@jeff-phillips-18 Just confirming that creating the binding from the service instance row still works. I thought we had blocked that when pod_presets was false previously

@jeff-phillips-18
Copy link
Member Author

@spadgett you are able to create the binding with pod_presets false. Not sure if this was in error before, but its working now ;)

@jeff-phillips-18
Copy link
Member Author

jeff-phillips-18 commented Sep 5, 2017

ENABLE_TECH_PREVIEW_FEATURE: { // Enable the new landing page and service catalog experience service_catalog_landing_page: true, // Set totruewhen the template service broker is enabled for the cluster in master-config.yaml template_service_broker: false, pod_presets: false },
image

@spadgett
Copy link
Member

spadgett commented Sep 6, 2017

[merge]

@openshift-bot
Copy link

[Test]ing while waiting on the merge queue

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2017
@openshift-bot
Copy link

Evaluated for origin web console test up to 3fc98ca

@openshift-bot
Copy link

Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/135/) (Base Commit: 0e7d693) (PR Branch Commit: 3fc98ca)

@spadgett
Copy link
Member

spadgett commented Sep 6, 2017

Flake #2016

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 3fc98ca

@openshift-bot
Copy link

openshift-bot commented Sep 6, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/121/) (Base Commit: 2fbc58a) (PR Branch Commit: 3fc98ca)

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2017
@openshift-bot openshift-bot merged commit b919687 into openshift:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants