Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing table-hover from tables to address inconsistency in hover color #2011

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Removing table-hover from tables to address inconsistency in hover color #2011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/browse/build-config.html
View file
Original file line number Diff line number Diff line change
@@ -178,7 +178,7 @@ <h2>No builds.</h2>
</div>
</div>
</div>
<table ng-if="!(buildConfig | isJenkinsPipelineStrategy)" class="table table-bordered table-hover table-mobile">
<table ng-if="!(buildConfig | isJenkinsPipelineStrategy)" class="table table-bordered table-mobile">
<thead>
<tr>
<th>Build</th>
@@ -220,7 +220,7 @@ <h2>No builds.</h2>
</table>
<div ng-if="buildConfig | isJenkinsPipelineStrategy">
<build-pipeline build="build" ng-repeat="build in orderedBuilds track by (build | uid)"></build-pipeline>
<table ng-if="(builds | hashSize) === 0" class="table table-bordered table-hover table-mobile">
<table ng-if="(builds | hashSize) === 0" class="table table-bordered table-mobile">
<tbody><tr><td><em>{{emptyMessage}}</em></td></tr></tbody>
</table>
</div>
2 changes: 1 addition & 1 deletion app/views/browse/config-maps.html
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ <h1>
<div class="col-md-12">
<div ng-if="!loaded">Loading...</div>
<div ng-if="loaded">
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-5">
</colgroup>
2 changes: 1 addition & 1 deletion app/views/browse/deployment-config.html
View file
Original file line number Diff line number Diff line change
@@ -129,7 +129,7 @@ <h1 class="contains-actions">
</div>
</div>
</div>
<table class="table table-bordered table-hover table-mobile">
<table class="table table-bordered table-mobile">
<thead>
<tr>
<th>Deployment</th>
2 changes: 1 addition & 1 deletion app/views/browse/deployment.html
View file
Original file line number Diff line number Diff line change
@@ -90,7 +90,7 @@ <h1 class="contains-actions">
</div>
</div>
</div>
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-2">
<col class="col-sm-4">
2 changes: 1 addition & 1 deletion app/views/browse/routes.html
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ <h1>
<alerts alerts="alerts"></alerts>
<div class="row">
<div class="col-md-12">
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-3">
<col class="col-sm-3">
2 changes: 1 addition & 1 deletion app/views/browse/stateful-sets.html
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ <h1>
<div ng-if="!loaded">Loading...</div>
<div class="row" ng-if="loaded">
<div class="col-md-12">
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-5">
</colgroup>
2 changes: 1 addition & 1 deletion app/views/builds.html
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ <h1>
<alerts alerts="alerts"></alerts>
<div class="row">
<div class="col-md-12">
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-2">
<col class="col-sm-1">
8 changes: 4 additions & 4 deletions app/views/deployments.html
View file
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ <h1>
<div class="row">
<div class="col-md-12">
<h3 ng-if="(deployments | size) || (replicaSets | size)">Deployment Configurations</h3>
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-3">
<col class="col-sm-2">
@@ -110,7 +110,7 @@ <h3 ng-if="(deployments | size) || (replicaSets | size)">Deployment Configuratio
</table>
<div ng-if="deployments | size">
<h3>Deployments</h3>
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-4">
<col class="col-sm-2">
@@ -155,7 +155,7 @@ <h3>Deployments</h3>
</div>
<div ng-if="replicaSets | hashSize" id="replica-sets">
<h3>Replica Sets</h3>
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-4">
</colgroup>
@@ -183,7 +183,7 @@ <h3>Replica Sets</h3>
</div>
<div ng-if="(unfilteredReplicationControllers | hashSize) > 0" id="replica-controllers">
<h3>Other Replication Controllers</h3>
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-5">
</colgroup>
2 changes: 1 addition & 1 deletion app/views/directives/events.html
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@
</div>
</div>
</div>
<table class="table table-bordered table-condensed table-mobile table-hover table-layout-fixed events-table">
<table class="table table-bordered table-condensed table-layout-fixed events-table">
<thead>
<tr>
<th id="time">Time</th>
2 changes: 1 addition & 1 deletion app/views/directives/pods-table.html
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-4">
<col class="col-sm-3">
2 changes: 1 addition & 1 deletion app/views/directives/traffic-table.html
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- Table combining routes and ports for a service -->
<table class="table table-bordered table-hover table-mobile">
<table class="table table-bordered table-mobile">
<thead>
<tr>
<th>{{customNameHeader || 'Route'}}<span ng-if="showNodePorts"> / Node Port</span></th>
2 changes: 1 addition & 1 deletion app/views/images.html
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ <h1>
<alerts alerts="alerts"></alerts>
<div class="row">
<div class="col-md-12">
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-3">
<col class="col-sm-5">
2 changes: 1 addition & 1 deletion app/views/secrets.html
View file
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ <h1>
<div ng-if="!loaded" class="mar-top-xl">Loading...</div>
<div ng-if="loaded" class="row">
<div class="col-md-12">
<table class="table table-bordered table-hover table-mobile secrets-table table-layout-fixed">
<table class="table table-bordered table-mobile secrets-table table-layout-fixed">
<colgroup>
<col class="col-sm-5">
<col class="col-sm-5">
2 changes: 1 addition & 1 deletion app/views/services.html
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ <h1>
<alerts alerts="alerts"></alerts>
<div class="row">
<div class="col-md-12">
<table class="table table-bordered table-hover table-mobile table-layout-fixed">
<table class="table table-bordered table-mobile table-layout-fixed">
<colgroup>
<col class="col-sm-3">
</colgroup>
2 changes: 1 addition & 1 deletion app/views/storage.html
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ <h2>Persistent Volume Claims</h2>
<a ng-if="outOfClaims" href="" class="btn btn-default disabled" aria-disabled="true">Create Storage</a>
</div>
</div>
<table class="table table-bordered table-hover table-mobile table-layout-fixed" ng-class="{ 'table-empty': (pvcs | hashSize) === 0 }">
<table class="table table-bordered table-mobile table-layout-fixed" ng-class="{ 'table-empty': (pvcs | hashSize) === 0 }">
<colgroup>
<col class="col-sm-5">
</colgroup>
38 changes: 19 additions & 19 deletions dist/scripts/templates.js
View file
Original file line number Diff line number Diff line change
@@ -1743,7 +1743,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</div>\n" +
"</div>\n" +
"</div>\n" +
"<table ng-if=\"!(buildConfig | isJenkinsPipelineStrategy)\" class=\"table table-bordered table-hover table-mobile\">\n" +
"<table ng-if=\"!(buildConfig | isJenkinsPipelineStrategy)\" class=\"table table-bordered table-mobile\">\n" +
"<thead>\n" +
"<tr>\n" +
"<th>Build</th>\n" +
@@ -1785,7 +1785,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</table>\n" +
"<div ng-if=\"buildConfig | isJenkinsPipelineStrategy\">\n" +
"<build-pipeline build=\"build\" ng-repeat=\"build in orderedBuilds track by (build | uid)\"></build-pipeline>\n" +
"<table ng-if=\"(builds | hashSize) === 0\" class=\"table table-bordered table-hover table-mobile\">\n" +
"<table ng-if=\"(builds | hashSize) === 0\" class=\"table table-bordered table-mobile\">\n" +
"<tbody><tr><td><em>{{emptyMessage}}</em></td></tr></tbody>\n" +
"</table>\n" +
"</div>\n" +
@@ -2231,7 +2231,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<div class=\"col-md-12\">\n" +
"<div ng-if=\"!loaded\">Loading...</div>\n" +
"<div ng-if=\"loaded\">\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-5\">\n" +
"</colgroup>\n" +
@@ -2378,7 +2378,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</div>\n" +
"</div>\n" +
"</div>\n" +
"<table class=\"table table-bordered table-hover table-mobile\">\n" +
"<table class=\"table table-bordered table-mobile\">\n" +
"<thead>\n" +
"<tr>\n" +
"<th>Deployment</th>\n" +
@@ -2656,7 +2656,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</div>\n" +
"</div>\n" +
"</div>\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-2\">\n" +
"<col class=\"col-sm-4\">\n" +
@@ -3483,7 +3483,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<alerts alerts=\"alerts\"></alerts>\n" +
"<div class=\"row\">\n" +
"<div class=\"col-md-12\">\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-3\">\n" +
"<col class=\"col-sm-3\">\n" +
@@ -3878,7 +3878,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<div ng-if=\"!loaded\">Loading...</div>\n" +
"<div class=\"row\" ng-if=\"loaded\">\n" +
"<div class=\"col-md-12\">\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-5\">\n" +
"</colgroup>\n" +
@@ -3943,7 +3943,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<alerts alerts=\"alerts\"></alerts>\n" +
"<div class=\"row\">\n" +
"<div class=\"col-md-12\">\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-2\">\n" +
"<col class=\"col-sm-1\">\n" +
@@ -4954,7 +4954,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<div class=\"row\">\n" +
"<div class=\"col-md-12\">\n" +
"<h3 ng-if=\"(deployments | size) || (replicaSets | size)\">Deployment Configurations</h3>\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-3\">\n" +
"<col class=\"col-sm-2\">\n" +
@@ -5040,7 +5040,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</table>\n" +
"<div ng-if=\"deployments | size\">\n" +
"<h3>Deployments</h3>\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-4\">\n" +
"<col class=\"col-sm-2\">\n" +
@@ -5085,7 +5085,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</div>\n" +
"<div ng-if=\"replicaSets | hashSize\" id=\"replica-sets\">\n" +
"<h3>Replica Sets</h3>\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-4\">\n" +
"</colgroup>\n" +
@@ -5113,7 +5113,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</div>\n" +
"<div ng-if=\"(unfilteredReplicationControllers | hashSize) > 0\" id=\"replica-controllers\">\n" +
"<h3>Other Replication Controllers</h3>\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-5\">\n" +
"</colgroup>\n" +
@@ -6627,7 +6627,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</div>\n" +
"</div>\n" +
"</div>\n" +
"<table class=\"table table-bordered table-condensed table-mobile table-hover table-layout-fixed events-table\">\n" +
"<table class=\"table table-bordered table-condensed table-layout-fixed events-table\">\n" +
"<thead>\n" +
"<tr>\n" +
"<th id=\"time\">Time</th>\n" +
@@ -8512,7 +8512,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(


$templateCache.put('views/directives/pods-table.html',
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-4\">\n" +
"<col class=\"col-sm-3\">\n" +
@@ -8764,7 +8764,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(


$templateCache.put('views/directives/traffic-table.html',
" <table class=\"table table-bordered table-hover table-mobile\">\n" +
" <table class=\"table table-bordered table-mobile\">\n" +
"<thead>\n" +
"<tr>\n" +
"<th>{{customNameHeader || 'Route'}}<span ng-if=\"showNodePorts\"> / Node Port</span></th>\n" +
@@ -9978,7 +9978,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<alerts alerts=\"alerts\"></alerts>\n" +
"<div class=\"row\">\n" +
"<div class=\"col-md-12\">\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-3\">\n" +
"<col class=\"col-sm-5\">\n" +
@@ -12831,7 +12831,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<div ng-if=\"!loaded\" class=\"mar-top-xl\">Loading...</div>\n" +
"<div ng-if=\"loaded\" class=\"row\">\n" +
"<div class=\"col-md-12\">\n" +
"<table class=\"table table-bordered table-hover table-mobile secrets-table table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile secrets-table table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-5\">\n" +
"<col class=\"col-sm-5\">\n" +
@@ -12896,7 +12896,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<alerts alerts=\"alerts\"></alerts>\n" +
"<div class=\"row\">\n" +
"<div class=\"col-md-12\">\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-3\">\n" +
"</colgroup>\n" +
@@ -13030,7 +13030,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"<a ng-if=\"outOfClaims\" href=\"\" class=\"btn btn-default disabled\" aria-disabled=\"true\">Create Storage</a>\n" +
"</div>\n" +
"</div>\n" +
"<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\" ng-class=\"{ 'table-empty': (pvcs | hashSize) === 0 }\">\n" +
"<table class=\"table table-bordered table-mobile table-layout-fixed\" ng-class=\"{ 'table-empty': (pvcs | hashSize) === 0 }\">\n" +
"<colgroup>\n" +
"<col class=\"col-sm-5\">\n" +
"</colgroup>\n" +
Loading