Adjust notification drawer events to show #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
spadgett
commented
Sep 6, 2017
•
spadgett
commented
- Show events when pods fail to schedule
- Show an event for invalid environment variable names
- Remove ErrorAsyncOperationInProgress and ReferencesNonexistentInstance because they are expected and generate a lot of noise with in-context bind.
spadgett
force-pushed
the
more-events
branch
4 times, most recently
from
a7609ad to
05102f0
Compare
dtaylor113
approved these changes
Sep 8, 2017
jeff-phillips-18
approved these changes
Sep 8, 2017
|
[merge][severity: bug] |
|
Looks like flake #1684 [merge][severity: bug] |
|
[merge][severity: bug] |
1 similar comment
|
[merge][severity: bug] |
|
[merge][severity: bug] |
|
[test] |
[launcher] Process exited with error code 1
>> A Jasmine spec timed out. Resetting the WebDriver Control Flow.
>> The last active task was:
>> unknown
>> A Jasmine spec timed out. Resetting the WebDriver Control Flow.
>> The last active task was:
>> unknown
>> A Jasmine spec timed out. Resetting the WebDriver Control Flow.
>> The last active task was:
>> unknown
Fatal error: protractor exited with code: 1�Re origin issue 16279 |
- Show events when pods fail to schedule - Show an event for invalid environment variable names - Remove ErrorAsyncOperationInProgress and ReferencesNonexistentInstance because they are expected and generate a lot of noise with in-context bind.
spadgett
force-pushed
the
more-events
branch
from
05102f0 to
c94ffd5
Compare
|
Evaluated for origin web console test up to c94ffd5 |
|
Origin Web Console Test Results: Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/159/) (Base Commit: db9abb5) (PR Branch Commit: c94ffd5) |
|
Evaluated for origin web console merge up to c94ffd5 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/155/) (Base Commit: db9abb5) (PR Branch Commit: c94ffd5) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.