Skip to content

Changes to masthead and vertical nav based on ux designs #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Sep 7, 2017

  • update color variables
  • consolidate/rename where appropriate
  • remove unused variables

Here are the colors for the masthead:
The top bar would be the standard pf-black #030303
The secondary masthead bar would be pf-black-900, #292e345

The vertical nav colors should be:
Main background color (default): pf-black-900, #292e34
Main background color (hover/selected): new color, #383f47
I'm introducing a new color here (very slightly tweaked from “pf-black-800”) because I believe we have a slight issue with the "pf-black-800" in our color palette. It is slightly too warmI'll look into updating our color palette in PF.

Vertical Nav Icons (default grey): pf-black-600, #383f47

note: @color-pf-black-600 is #72767b

Vertical Nav Icons (selected blue): pf-blue-300, #39a5dc

localhost-9000-dev-console-
localhost-9000-dev-console- 1

@rhamilto @spadgett
cc @jennyhaines

- update color variables and rename where appropriate
- remove unused variables
@spadgett spadgett requested a review from rhamilto September 7, 2017 13:53
@spadgett
Copy link
Member

spadgett commented Sep 7, 2017

@serenamarie125 FYI

@spadgett
Copy link
Member

spadgett commented Sep 7, 2017

[merge][severity: bug]

@rhamilto
Copy link
Member

rhamilto commented Sep 7, 2017

Wondering if the landing page sidebar background is too blue now in comparison to the left nav sidebar? @jennyhaines, your thoughts?

@openshift-bot
Copy link

Evaluated for origin web console merge up to 60793a1

@openshift-bot
Copy link

openshift-bot commented Sep 7, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/143/) (Base Commit: 230c9b4) (PR Branch Commit: 60793a1) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit eb411d5 into openshift:master Sep 7, 2017
@jennyhaines
Copy link

@rhamilto , I do see what you're saying about the landing page projects sidebar. I'd think it would be optimal to change this background color to the same color as the vertical nav background. Nice catch!

@sg00dwin , great color changes- looks good! I think just one more change will hit it outta the park... do you mind changing the background color of the landing page projects sidebar to pf-black-900, #292e34 ? (the same color of the vertical nav background)

@spadgett
Copy link
Member

spadgett commented Sep 7, 2017

Project sidebar changes: openshift/origin-web-catalog#421

@sg00dwin sg00dwin deleted the color-updates branch September 11, 2017 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants