Use new ApplicationsService.getApplications utility #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
approved these changes
Sep 8, 2017
jeff-phillips-18
force-pushed
the
applications
branch
from
f4b2e9a to
a755f74
Compare
jeff-phillips-18
changed the title
|
Removed WIP status |
spadgett
previously approved these changes
Sep 15, 2017
spadgett
dismissed
their stale review
Shouldn't need to sort here since the service does it
spadgett
requested changes
Sep 15, 2017
| statefulSets = _.toArray(statefulSetData.by('metadata.name')); | ||
| sortApplications(); | ||
| ApplicationsService.getApplications(context).then(function(applications) { | ||
| ctrl.applications = _.sortBy(applications, ['metadata.name', 'kind']); |
There was a problem hiding this comment.
ApplicationService sorts, so we shouldn't need to sort here.
| statefulSets = _.toArray(statefulSetData.by('metadata.name')); | ||
| sortApplications(); | ||
| ApplicationsService.getApplications(context).then(function(applications) { | ||
| ctrl.applications = _.sortBy(applications, ['metadata.name', 'kind']); |
jeff-phillips-18
force-pushed
the
applications
branch
from
a755f74 to
2e78f9f
Compare
spadgett
approved these changes
Sep 15, 2017
There was a problem hiding this comment.
Thanks @jeff-phillips-18, nice to see so much duplicate code removed
|
[merge] |
|
Evaluated for origin web console merge up to 2e78f9f |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/204/) (Base Commit: 3826410) (PR Branch Commit: 2e78f9f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.